Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Commit

Permalink
Pin cmake_format to version 0.4.5. (#317)
Browse files Browse the repository at this point in the history
Version 0.5.1 changes the formatting (which breaks "check format" on
travis) but also breaks add_library(ALIAS) so we can't upgrade.

Upstream issue: https://github.com/cheshirekow/cmake_format/issues/111
  • Loading branch information
g-easy authored May 10, 2019
1 parent 7c3607b commit c59a897
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/docker-format/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ FROM ubuntu:cosmic
RUN apt update && \
apt install -y clang-format golang git python-pip && \
go get -v github.com/bazelbuild/buildtools/buildifier && \
pip install cmake_format
pip install cmake_format==0.4.5

CMD ["/bin/bash"]
2 changes: 1 addition & 1 deletion tools/travis/check_format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ if ! which buildifier >/dev/null; then
go get -v github.com/bazelbuild/buildtools/buildifier
fi
# Install cmake-format.
pip install --user cmake_format
pip install --user cmake_format==0.4.5
# Check format.
tools/format.sh

0 comments on commit c59a897

Please sign in to comment.