This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add an option to set metric name prefix #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rghetia
reviewed
Jun 12, 2020
options.go
Outdated
| } | ||
|
|
||
| // UseMetricNamePrefix provides an option for the caller to add a prefix to metric names. | ||
| func UseMetricNamePrefix(prefix string) ExporterOption { |
There was a problem hiding this comment.
s/UseMetricNamePrefix/WithMetricNamePrefix/
rghetia
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In knative we need to set the component names(autoscaler and activator) as the prefix for metric names. Both prometheus and stackdriver provide a way to do that:
https://github.com/census-ecosystem/opencensus-go-exporter-prometheus/blob/master/prometheus.go#L170
https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/blob/master/metrics_proto.go#L413
This PR brings the parity to opencensus agent.
It's hard to test without a mock agent for metrics. But I tested manually and it worked as expected.