-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List community RPC nodes #470
Conversation
🦋 Changeset detectedLatest commit: 7ec4a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 76.09% 76.18% +0.09%
==========================================
Files 244 245 +1
Lines 10253 10310 +57
Branches 1626 1627 +1
==========================================
+ Hits 7802 7855 +53
- Misses 2338 2367 +29
+ Partials 113 88 -25
|
im getting huge errors when i run this on alfajores (and mainnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some case that needs to be handled.
yarn celocli network:rpc-urls --node alfajores --all
Received an error during command execution, if you believe this is a bug you can create an issue here:
https://github.com/celo-org/developer-tooling/issues/new?assignees=&labels=bug+report&projects=&template=BUG-FORM.yml
Error: Invalid value "ATTESTATION_SERVICE_URL" supplied to : { claims: Array<(AccountClaimType | { type: "DOMAIN", timestamp: number, domain: string } | { type: "RPC_URL", timestamp: number, rpcUrl: string } | { type: "KEYBASE", timestamp: number, username: string } | { type: "NAME", timestamp: number, name: string } | { type: "STORAGE", timestamp: number, address: string, filteredDataPaths: string })>, meta: { address: Address, signature: string } }/claims: Array<(AccountClaimType | { type: "DOMAIN", timestamp: number, domain: string } | { type: "RPC_URL", timestamp: number, rpcUrl: string } | { type: "KEYBASE", timestamp: number, username: string } | { type: "NAME", timestamp: number, name: string } | { type: "STORAGE", timestamp: number, address: string, filteredDataPaths: string })>/1: (AccountClaimType | { type: "DOMAIN", timestamp: number, domain: string } | { type: "RPC_URL", timestamp: number, rpcUrl: string } | { type: "KEYBASE", timestamp: number, username: string }
…test coverage, changesets
…rg/developer-tooling into shazarre/List_community_RPC_nodes
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14107627 | Triggered | Generic High Entropy Secret | b9a0ad8 | packages/cli/src/commands/account/new.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful PR. but we are putting it on hold for until next year
Description
This PR adds a command to list (all/from elected validator groups) community RPC node URLs.
Other changes
None.
Tested
Tested locally, CI tests are passing.
How to QA
anvil --port 8545 --load-state node_modules/@celo/devchain-anvil/l2-devchain.json --balance 100000 --base-fee 0 --timestamp 1718872285 --mnemonic "concert load couple harbor equip island argue ramp clarify fence smart topic"
NO_SYNCCHECK=1 yarn workspace @celo/celocli run dev validator:list --node local
, add--csv
flag if you cannot copy the full validator address)cast rpc anvil_impersonateAccount "0x15d34AAf54267DB7D7c367839AAf71A00a2C6A65"
NO_SYNCCHECK=1 yarn workspace @celo/celocli run dev account:register-metadata --url https://gist.githubusercontent.com/shazarre/dc6e3c2b44abccbb5af0fba1f519dde7/raw/7014424afd11c0ba0c93d36284d19beeb3d0a962/metadata-test.json --node local --from 0x15d34AAf54267DB7D7c367839AAf71A00a2C6A65
yarn workspace @celo/celocli run prepack
first)Related issues
PR-Codex overview
This PR introduces a new command to list community RPC nodes and enhances backwards compatibility for existing claims related to
ATTESTATION_SERVICE_URL
. It also updates related documentation and tests accordingly.Detailed summary
validatorgroup:rpc-urls
command to list community RPC nodes.ATTESTATION_SERVICE_URL
claims.metadata.ts
.ATTESTATION_SERVICE_URL
claims.