Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CeloCli Approval fix #9925

Merged
merged 3 commits into from
Oct 10, 2022
Merged

CeloCli Approval fix #9925

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b7444c
Approval fix
Oct 10, 2022
7ba5c33
storage version check added
Oct 10, 2022
135b193
lint
Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/cli/src/commands/governance/approve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,14 @@ export default class Approve extends BaseCommand {
await governance.dequeueProposalsIfReady().sendAndWaitForReceipt()
}

const governanceVersion = await governance.version()

await checkBuilder
.proposalExists(id)
.proposalInStage(id, 'Referendum')
.proposalInStage(
id,
governanceVersion.storage === 1 && governanceVersion.major < 3 ? 'Approval' : 'Referendum'
)
.addCheck(`${id} not already approved`, async () => !(await governance.isApproved(id)))
.runChecks()
governanceTx = await governance.approve(id)
Expand Down