Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix lookup* functionality #9577

Merged
merged 26 commits into from
May 23, 2022
Merged

Add and fix lookup* functionality #9577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4a74740
Return counts per issuer for lookupAttestations
eelanagaraj May 13, 2022
0c6a04a
Return counts per issuer for lookupIdentifiersByAddress
eelanagaraj May 13, 2022
296cd82
Add lookupAllAttestations (+ helper getTotalNumberOfAttestations) and…
eelanagaraj May 13, 2022
17c4a9c
Add getNumberOfUnrevokedAttestations and tests
eelanagaraj May 13, 2022
e8a1815
Nit: fix ordering of expectations and actuals in check helper funcs
eelanagaraj May 13, 2022
52d282d
Add getNumberOfUnrevokedIdentifiers and tests
eelanagaraj May 13, 2022
b340c8c
Fix var naming in getTotalNumberOfAttestations
eelanagaraj May 13, 2022
7c1f989
Add getTotalNumberOfIdentifiers and tests
eelanagaraj May 13, 2022
9e88e0c
Add lookupAllIdentifiersByAddress (+ helper getTotalNumberOfIdentifie…
eelanagaraj May 13, 2022
7501a32
Reorganize tests for looking up attestations
eelanagaraj May 16, 2022
ad40f91
Reorganize tests for looking up identifiers
eelanagaraj May 16, 2022
b16c547
Fix scope of test helper functions
eelanagaraj May 16, 2022
11649fb
Address ASv2 PR comments
eelanagaraj May 16, 2022
02b1a74
Add mini-fixes post benchmarking
eelanagaraj May 16, 2022
6917365
Make getTotalNumberOf* functions internal
eelanagaraj May 16, 2022
c18ed1e
Add comments to address PR review
eelanagaraj May 19, 2022
898b66e
Add includeRevoked param to lookupAllAttestations
eelanagaraj May 19, 2022
ded1b31
Add includeRevoked param to lookupAllIdentifiersByAddress
eelanagaraj May 19, 2022
001d849
Fix docstrings
eelanagaraj May 19, 2022
7e886b2
Rename lookup functions and helpers
eelanagaraj May 19, 2022
c4de08d
Nit use ternary assignment
eelanagaraj May 19, 2022
4cc917f
Rename identifierToAddresses -> identifierToAttestations
eelanagaraj May 19, 2022
d3b1b7f
Unnest if statements in lookup funcs to address PR comments
eelanagaraj May 23, 2022
ebe729f
Fix and update TODOs to include DNM
eelanagaraj May 23, 2022
8c19080
Fix lint checks
eelanagaraj May 23, 2022
0f2a200
Remove DNM as this blocks linting :-|
eelanagaraj May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading