-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create StableToken registry #9346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvol
reviewed
Feb 25, 2022
martinvol
reviewed
Feb 25, 2022
martinvol
reviewed
Feb 25, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 18, 2022
martinvol
reviewed
Mar 29, 2022
martinvol
reviewed
Mar 29, 2022
martinvol
reviewed
Mar 29, 2022
martinvol
reviewed
Mar 29, 2022
martinvol
reviewed
Mar 29, 2022
ninabarbakadze
force-pushed
the
ninabarbakadze/stable-token-registry
branch
from
May 6, 2022 09:27
061f811
to
6d0eab2
Compare
aaronmgdr
reviewed
May 6, 2022
martinvol
reviewed
May 10, 2022
martinvol
reviewed
May 17, 2022
martinvol
reviewed
May 17, 2022
martinvol
reviewed
May 17, 2022
martinvol
reviewed
May 17, 2022
martinvol
reviewed
May 17, 2022
This pr should not be merged until the core contracts release process gets finalised |
martinvol
reviewed
May 17, 2022
martinvol
reviewed
May 17, 2022
Authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain>
….com/celo-org/celo-monorepo into ninabarbakadze/stable-token-registry
martinvol
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!
martinvol
added a commit
that referenced
this pull request
Sep 21, 2022
* initial contract creation * added a contructor and a mapping * added function that add fiat tickers into the collection * function that returns all the fiat symbols thats been issued * quering a stable contract functionality * function to retrieve all the contract instances from a mapping * removing unnecessary imports * function that returns all the contracts * added comments * removed unnecessary function * removed unnecessary function * functionality to remove unsupported tokens * function that adds new instances to the registry * poor indentation * resolving bugs * suggested improvements * writing initialize * updated inconsistent syntax * initialize function is implemented * some of the resolved compile errors * resolving compiler issues * last of compiler issues * upgrading removeStableToken funrction * updated registry * updated initialize function * removed commented out code * updated comments * created a proxy * updating build file * updated build file * initialize test suit * updating registry contract * first few tests are passing * remove stableToken function * resolving a mistake * resolving based on corrections * tests for remove function complete * test suit for adding contracts * tests pass * adding more arguments to compare * adding registry contract to the registry * registry migrations * unsaved changes * bug fixed in initialized and two more found it addnewstabletoken * refactoring get contracts function * converted to bytes and contract compiles * initialize function added to tests * 8 tests pass, refactoring the contract * latest * fixing bugs * everything works ✨ * added a contraxt query function + tests * lists all the correct contract namea after adding and removing one ✨😭 * all functions are fully tested and work * adding it to the registry * finished * fixed migrations * amount of arguments in initialize error fixed * bug * had an accidental type in reserve * migration tests pass * one minor fix needed * removed from registry * readded in registry-utils * upgraded the number of migration file the tests should run to * cleaning up * applying suggestions * error in ts wrapper * fixed migration error * initial contract creation * added a contructor and a mapping * added function that add fiat tickers into the collection * function that returns all the fiat symbols thats been issued * quering a stable contract functionality * function to retrieve all the contract instances from a mapping * removing unnecessary imports * function that returns all the contracts * added comments * removed unnecessary function * removed unnecessary function * functionality to remove unsupported tokens * function that adds new instances to the registry * poor indentation * resolving bugs * suggested improvements * writing initialize * updated inconsistent syntax * initialize function is implemented * some of the resolved compile errors * resolving compiler issues * last of compiler issues * upgrading removeStableToken funrction * updated registry * updated initialize function * removed commented out code * updated comments * created a proxy * updating build file * updated build file * initialize test suit * updating registry contract * first few tests are passing * remove stableToken function * resolving a mistake * resolving based on corrections * tests for remove function complete * test suit for adding contracts * tests pass * adding more arguments to compare * adding registry contract to the registry * registry migrations * unsaved changes * bug fixed in initialized and two more found it addnewstabletoken * refactoring get contracts function * converted to bytes and contract compiles * initialize function added to tests * 8 tests pass, refactoring the contract * latest * fixing bugs * everything works ✨ * added a contraxt query function + tests * lists all the correct contract namea after adding and removing one ✨😭 * all functions are fully tested and work * adding it to the registry * finished * fixed migrations * amount of arguments in initialize error fixed * bug * had an accidental type in reserve * migration tests pass * one minor fix needed * removed from registry * readded in registry-utils * upgraded the number of migration file the tests should run to * cleaning up * applying suggestions * error in ts wrapper * fixed migration error * added an empty object in release9 * release tag update * updating correct release tag * removed unnecessary release9 json file * updating the release tag * add release report * update the path for ci * correct ci path * removed incorrect configs * Trying to get all the tags from git * try to add on devchain * Fixed branch name * Restored a missing test (#9460) Authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain> * Consistent code across GrandaMento and Exchange in setSpread (#9459) * Fix Oracle check (#9527) * Add version report * Added newline at the end * Fixed release versions * Deleted wrong files * adding a version number * updated the major version number to 1 * Create release8.json * Update release8.json * Update release8.json * Update release8.json * Update StableTokenRegistry.sol Co-authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain> Co-authored-by: Nina Barbakadze <ninabarbakadze@MacBook-Pro-4.local> Co-authored-by: Nina Barbakadze <ninabarbakadze@vd47kwk70w.localdomain> Co-authored-by: Martín Volpe <volpe@clabs.co> Co-authored-by: Martin Volpe <martin.volpe@gmail.com> Co-authored-by: Marcin Chrzanowski <martin@clabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pr I created a registry that has a single source of truth about what stable coins are deployed as part of Celo's Stability protocol.
Tested
Unit Tests
Related issues
Backwards compatibility
Should be backwards compatible