Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create StableToken registry #9346

Merged
merged 175 commits into from
Jul 5, 2022
Merged

Conversation

ninabarbakadze
Copy link
Contributor

Description

In this pr I created a registry that has a single source of truth about what stable coins are deployed as part of Celo's Stability protocol.

Tested

Unit Tests

Related issues

Backwards compatibility

Should be backwards compatible

@ninabarbakadze ninabarbakadze changed the title initial contract creation Create StableToken registry Feb 23, 2022
@ninabarbakadze ninabarbakadze force-pushed the ninabarbakadze/stable-token-registry branch from 061f811 to 6d0eab2 Compare May 6, 2022 09:27
@ninabarbakadze ninabarbakadze marked this pull request as ready for review May 6, 2022 11:21
@ninabarbakadze ninabarbakadze requested a review from a team May 6, 2022 11:21
@ninabarbakadze ninabarbakadze requested a review from a team as a code owner May 6, 2022 11:21
@celo-org celo-org deleted a comment from martinvol May 17, 2022
@ninabarbakadze
Copy link
Contributor Author

This pr should not be merged until the core contracts release process gets finalised

Base automatically changed from martinvol/master_CR7 to master July 4, 2022 14:44
@martinvol martinvol changed the base branch from master to martinvol/master_CR7_well July 5, 2022 11:23
Base automatically changed from martinvol/master_CR7_well to master July 5, 2022 13:03
@martinvol martinvol changed the base branch from master to ASv2 July 5, 2022 13:08
@martinvol martinvol changed the base branch from ASv2 to master July 5, 2022 13:08
Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@ninabarbakadze ninabarbakadze enabled auto-merge (squash) July 5, 2022 15:33
@ninabarbakadze ninabarbakadze merged commit 5d53d92 into master Jul 5, 2022
martinvol added a commit that referenced this pull request Sep 21, 2022
* initial contract creation

* added a contructor and a mapping

* added function that add fiat tickers into the collection

* function that returns all the fiat symbols thats been issued

* quering a stable contract functionality

* function to retrieve all the contract instances from a mapping

* removing unnecessary imports

* function that returns all the contracts

* added comments

* removed unnecessary function

* removed unnecessary function

* functionality to remove unsupported tokens

* function that adds new instances to the registry

* poor indentation

* resolving bugs

* suggested improvements

* writing initialize

* updated inconsistent syntax

* initialize function is implemented

* some of the resolved compile errors

* resolving compiler issues

* last of compiler issues

* upgrading removeStableToken funrction

* updated registry

* updated initialize function

* removed commented out code

* updated comments

* created a proxy

* updating build file

* updated build file

* initialize test suit

* updating registry contract

* first few tests are passing

* remove stableToken function

* resolving a mistake

* resolving based on corrections

* tests for remove function complete

* test suit for adding contracts

* tests pass

* adding more arguments to compare

* adding registry contract to the registry

* registry migrations

* unsaved changes

* bug fixed in initialized and two more found it addnewstabletoken

* refactoring get contracts function

* converted to bytes and contract compiles

* initialize function added to tests

* 8 tests pass, refactoring the contract

* latest

* fixing bugs

* everything works ✨

* added a contraxt query function + tests

* lists all the correct contract namea after adding and removing one ✨😭

* all functions are fully tested and work

* adding it to the registry

* finished

* fixed migrations

* amount of arguments in initialize error fixed

* bug

* had an accidental type in reserve

* migration tests pass

* one minor fix needed

* removed from registry

* readded in registry-utils

* upgraded the number of migration file the tests should run to

* cleaning up

* applying suggestions

* error in ts wrapper

* fixed migration error

* initial contract creation

* added a contructor and a mapping

* added function that add fiat tickers into the collection

* function that returns all the fiat symbols thats been issued

* quering a stable contract functionality

* function to retrieve all the contract instances from a mapping

* removing unnecessary imports

* function that returns all the contracts

* added comments

* removed unnecessary function

* removed unnecessary function

* functionality to remove unsupported tokens

* function that adds new instances to the registry

* poor indentation

* resolving bugs

* suggested improvements

* writing initialize

* updated inconsistent syntax

* initialize function is implemented

* some of the resolved compile errors

* resolving compiler issues

* last of compiler issues

* upgrading removeStableToken funrction

* updated registry

* updated initialize function

* removed commented out code

* updated comments

* created a proxy

* updating build file

* updated build file

* initialize test suit

* updating registry contract

* first few tests are passing

* remove stableToken function

* resolving a mistake

* resolving based on corrections

* tests for remove function complete

* test suit for adding contracts

* tests pass

* adding more arguments to compare

* adding registry contract to the registry

* registry migrations

* unsaved changes

* bug fixed in initialized and two more found it addnewstabletoken

* refactoring get contracts function

* converted to bytes and contract compiles

* initialize function added to tests

* 8 tests pass, refactoring the contract

* latest

* fixing bugs

* everything works ✨

* added a contraxt query function + tests

* lists all the correct contract namea after adding and removing one ✨😭

* all functions are fully tested and work

* adding it to the registry

* finished

* fixed migrations

* amount of arguments in initialize error fixed

* bug

* had an accidental type in reserve

* migration tests pass

* one minor fix needed

* removed from registry

* readded in registry-utils

* upgraded the number of migration file the tests should run to

* cleaning up

* applying suggestions

* error in ts wrapper

* fixed migration error

* added an empty object in release9

* release tag update

* updating correct release tag

* removed unnecessary release9 json file

* updating the release tag

* add release report

* update the path for ci

* correct ci path

* removed incorrect configs

* Trying to get all the tags from git

* try to add on devchain

* Fixed branch name

* Restored a missing test (#9460)

Authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain>

* Consistent code across GrandaMento and Exchange in setSpread (#9459)

* Fix Oracle check (#9527)

* Add version report

* Added newline at the end

* Fixed release versions

* Deleted wrong files

* adding a version number

* updated the major version number to 1

* Create release8.json

* Update release8.json

* Update release8.json

* Update release8.json

* Update StableTokenRegistry.sol

Co-authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain>
Co-authored-by: Nina Barbakadze <ninabarbakadze@MacBook-Pro-4.local>
Co-authored-by: Nina Barbakadze <ninabarbakadze@vd47kwk70w.localdomain>
Co-authored-by: Martín Volpe <volpe@clabs.co>
Co-authored-by: Martin Volpe <martin.volpe@gmail.com>
Co-authored-by: Marcin Chrzanowski <martin@clabs.co>
@mcortesi mcortesi deleted the ninabarbakadze/stable-token-registry branch August 23, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create on-chain registry for StableTokens contract
4 participants