-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signature verification code for CIP-40 requests #8859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nategraf
requested review from
barbaraliau,
gastonponti and
mcortesi
as code owners
October 28, 2021 22:43
nategraf
requested review from
emilhotkowski
and removed request for
a team,
timmoreton,
mcortesi,
gastonponti,
asaj and
barbaraliau
October 28, 2021 22:45
emilhotkowski
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This was referenced Apr 22, 2022
This was referenced May 26, 2022
This was referenced Aug 5, 2022
This was referenced Oct 6, 2022
This was referenced Apr 24, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds signature verification functions for the three new requests in the ODIS Domains API.
Signature creation and verification follows the specification of CIP-30. Verification is now implemented for use in other places. Signature creation is not implemented in a client library as part of this PR, but an example is given through the test code of how to create a valid signature.
Other changes
Tested