Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature verification code for CIP-40 requests #8859

Merged
merged 7 commits into from
Oct 29, 2021

Conversation

nategraf
Copy link
Contributor

@nategraf nategraf commented Oct 28, 2021

Description

Adds signature verification functions for the three new requests in the ODIS Domains API.

Signature creation and verification follows the specification of CIP-30. Verification is now implemented for use in other places. Signature creation is not implemented in a client library as part of this PR, but an example is given through the test code of how to create a valid signature.

Other changes

  • Add comments to domain structures and functions that did not already have comments.

Tested

  • Added a number of new unit tests to ensure the correctness of the verification code.

@nategraf nategraf marked this pull request as ready for review October 28, 2021 22:43
@nategraf nategraf requested a review from a team October 28, 2021 22:43
@nategraf nategraf requested review from emilhotkowski and removed request for a team, timmoreton, mcortesi, gastonponti, asaj and barbaraliau October 28, 2021 22:45
Copy link
Contributor

@emilhotkowski emilhotkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lvpeschke lvpeschke deleted the victor/sign-cip40-requests branch November 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants