Remove ERC20 from core contracts #8212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
approved these changes
Jul 4, 2021
|
Is there any reason for any contract that never gets directly instantiated to even be listed in |
good question @m-chrzan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RegisteredContractslist used in ContractKit for comprehensive registry lookup and governance proposal decoding (among others) errantly includesCeloContract.ERC20introduced in #7753 despite this not being a registered contract. This PR addsCeloContract.ERC20toAuxiliaryContractsto be filtered out.Tested
Before change,
Error: ERC20 not yet deployed for this chainis emitted on many CLI changes. After change, error is no longer observed.