Add token address support to oracle commands. #8010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5bdf01 to
1e4beef
Compare
tkporter
pushed a commit
that referenced
this pull request
Jul 8, 2021
* Add token address support to oracle commands. * Update documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows a celocli user to interact with the SortedOracles contract by passing an address (in addition to passing the token contract name). Currently, celocli only support two options: "StableToken" and "StableTokenEUR". This PR makes it so that it also accepts a report target address (e.g. 0x018CAad1ED69eeDD40ed8309A81Eb78c937563a6 for CELOBTC).
Other changes
Update commands help string to remove mention of supporting only cUSD (StableToken), when it already supports cEUR.
Tested
Manually tested the commands on baklava.
Backwards compatibility
This PR adds new functionality to the changed commands, but doesn't change the way it worked previously. The CLI remains compatible with all previous commands.
Documentation
Oclif docs updated.