Add script for running + testing eth_signTypedData #7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBHarley
reviewed
May 21, 2021
| // try { | ||
| // const testAddr = '0x12f0600c945826fe9be0ea08d7c6fd35df160749' | ||
| // console.log('sending typed data request') | ||
| // const signedData = await kit.signTypedData(testAddr, TYPED_DATA) |
There was a problem hiding this comment.
We should use the from variable
There was a problem hiding this comment.
oop yes good catch 😂 thanks!
AlexBHarley
approved these changes
May 21, 2021
mergify bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
May 27, 2021
### Description - implements `eth_signTypedData` ### Other changes - adds minimal additional error handling which should now be propagated as a response ### Tested - Manually via `use-contractkit` and by extending the `run-in-memory-client.ts` script in the `celo-monorepo` (in [this small PR](celo-org/celo-monorepo#7951)) ### Related issues - Fixes celo-org/celo-monorepo#7514 ### Backwards compatibility cc @medhak1 as this changes some of the structure in the `acceptRequest` function in `../saga.ts`, assuming that will be relevant for `personal_decrypt` or the other json RPC methods you're implementing!
medhakothari
pushed a commit
that referenced
this pull request
Jun 3, 2021
Related to valora-inc/wallet#389 (helpful for testing)
medhakothari
pushed a commit
that referenced
this pull request
Jun 3, 2021
Related to valora-inc/wallet#389 (helpful for testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to valora-inc/wallet#389 (helpful for testing)