Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove @umpirsky/country-list package to save space #7895

Merged
merged 4 commits into from
May 19, 2021
Merged

chore: remove @umpirsky/country-list package to save space #7895

merged 4 commits into from
May 19, 2021

Conversation

obasilakis
Copy link
Contributor

Description

Copied what we needed from @umpirsky/country-list to a folder and removed it to reduce package size.

Related issues

@obasilakis obasilakis requested review from barbaraliau, medhakothari and a team as code owners May 12, 2021 09:46
jmrossy
jmrossy reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. I think we can trim it even further :)

packages/sdk/utils/data/countries/es/country.json Show resolved Hide resolved
@obasilakis obasilakis force-pushed the obasilakis/remove-country-list-package branch from be23b52 to f704882 Compare May 12, 2021 15:57
barbaraliau
barbaraliau reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@barbaraliau barbaraliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Had a question on the deletion of the types file.

packages/sdk/utils/src/types.d.ts Show resolved Hide resolved
barbaraliau
barbaraliau approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@barbaraliau barbaraliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gastonponti
gastonponti approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@barbaraliau barbaraliau added the automerge Have PR merge automatically when checks pass label May 18, 2021
@mergify mergify bot merged commit a8f8387 into master May 19, 2021
@mergify mergify bot deleted the obasilakis/remove-country-list-package branch May 19, 2021 10:08
medhakothari pushed a commit that referenced this pull request Jun 3, 2021
@obasilakis
chore: remove @umpirsky/country-list package to save space (#7895)
f88cb14 
### Description

Copied what we needed from @umpirsky/country-list to a folder and removed it to reduce package size.

### Related issues

- Fixes #6421
medhakothari pushed a commit that referenced this pull request Jun 3, 2021
@obasilakis
chore: remove @umpirsky/country-list package to save space (#7895)
e0d1843 
### Description

Copied what we needed from @umpirsky/country-list to a folder and removed it to reduce package size.

### Related issues

- Fixes #6421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy left review comments

@gastonponti gastonponti gastonponti approved these changes

@barbaraliau barbaraliau barbaraliau approved these changes

@medhakothari medhakothari Awaiting requested review from medhakothari

Assignees
No one assigned
Labels
Applications Applications circle tasks automerge Have PR merge automatically when checks pass Component: ContractKit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce package size due to consumption of @umpirsky/country-list
4 participants
@obasilakis @jmrossy @gastonponti @barbaraliau