Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify approve and approvehotfix to support multisigs #7671

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Unify approve and approvehotfix to support multisigs #7671

merged 4 commits into from
Apr 14, 2021

Conversation

yorhodes
Copy link
Contributor

@yorhodes yorhodes commented Apr 9, 2021 •
edited
Loading

Description

Support --useMultiSig on governance:approvehotfix

Other changes

Remove governance:approvehotfix. in favor of governance:approve

Tested

./bin/run governance:approvehotfix --hotfix 0xfcfc98ec3db7c56f0866a7149e811bf7f9e30c9d40008b0def497fcc6fe90649 --from 0xCc50EaC48bA71343dC76852FAE1892c6Bd2971DA --privateKey a060fb3482170808fdfd5f1ed3e2bb87998bd976d5fbd82382205ff1557fd0d4 --node https://alfajores-forno.celo-testnet.org
Running Checks:
   ✔  0x15A38F364122e35F9479c53b9E32ad21a7519C49 is approver address
   ✔  0xCc50EaC48bA71343dC76852FAE1892c6Bd2971DA is multisig signatory
   ✔  Hotfix 0xfcfc98ec3db7c56f0866a7149e811bf7f9e30c9d40008b0def497fcc6fe90649 is not already executed
   ✔  Hotfix 0xfcfc98ec3db7c56f0866a7149e811bf7f9e30c9d40008b0def497fcc6fe90649 is not already approved
SendTransaction: approveTx
txHash: 0x33f6e0fa7fffc5d351b82ea9ac45b6171d46510c5da3a6e84f9c1fffc6f98490
Sending Transaction: approveTx... done

Backwards compatibility

Yes

Documentation

TBD

medhakothari
medhakothari approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@medhakothari medhakothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medhakothari medhakothari added the automerge Have PR merge automatically when checks pass label Apr 10, 2021
@yorhodes yorhodes force-pushed the approve-hotfix-multisig branch from ab863e6 to 904549e Compare April 13, 2021 23:40
@mergify mergify bot merged commit 5753195 into master Apr 14, 2021
@gastonponti gastonponti mentioned this pull request Apr 26, 2021
Closed
@aaronmgdr aaronmgdr deleted the approve-hotfix-multisig branch August 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medhakothari medhakothari medhakothari approved these changes

@gastonponti gastonponti Awaiting requested review from gastonponti

@mcortesi mcortesi Awaiting requested review from mcortesi

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorhodes @medhakothari