Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug with >iOS 13 opening app store link #7658

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Fixes bug with >iOS 13 opening app store link #7658

merged 3 commits into from
Apr 9, 2021

Conversation

eelanagaraj
Copy link
Contributor

Fixes an issue with react canOpenURL for iOS >= 13.

Tested

  • Expo Go on iPhone (XR)
  • Expo Go on Android (Pixel 3)

@eelanagaraj eelanagaraj requested review from AlexBHarley and removed request for mcortesi April 9, 2021 11:57
@eelanagaraj eelanagaraj added the automerge Have PR merge automatically when checks pass label Apr 9, 2021
gastonponti
gastonponti approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ecdae5f into master Apr 9, 2021
@mergify mergify bot deleted the eelanagaraj/dappkit-ios-bugfix branch April 9, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonponti gastonponti gastonponti approved these changes

@barbaraliau barbaraliau Awaiting requested review from barbaraliau

@medhakothari medhakothari Awaiting requested review from medhakothari

@AlexBHarley AlexBHarley Awaiting requested review from AlexBHarley

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eelanagaraj @gastonponti