Update @celo/utils to allow AccountAuthResponseSuccess to include pepper #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
eelanagaraj
reviewed
Mar 29, 2021
| import { PhoneNumberUtils } from '@celo/utils' | ||
| const attestations = await kit.contracts.getAttestations() | ||
|
|
||
| const identifier = PhoneNumberUtils.getPhoneHash(dappkitResponse.phoneNumber, dappkitResponse.pepper) |
There was a problem hiding this comment.
Looks great! One nit: we are trying to standardize the style in the docs; could you add semi-colons to the end of the lines in this code snippet? Other than that looks good!
eelanagaraj
reviewed
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional field for the pepper to be passed as part of the dappkit response. It also updates the dappkit docs to indicate usage whenever it will be deployed as part of Valora (which requires this to be published first)
Tested
Related issues
Backwards compatibility