Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small fixes for WalletConnect alpha.32 #7507

Merged
merged 10 commits into from
Mar 25, 2021
Merged

fix: small fixes for WalletConnect alpha.32 #7507

merged 10 commits into from
Mar 25, 2021

Conversation

AlexBHarley
Copy link
Contributor

@AlexBHarley AlexBHarley commented Mar 23, 2021 •
edited
Loading

Description

There has been a few breaking changes as part of the WalletConnect alpha tumult.

Other changes

Added the scripts run-in-memory-client and run-in-memory-wallet as the most bare bones sanity test you can run. You run the client, copy the URL and then run the wallet.

Also nice for testing automated flows,

  • I can run a wallet (Valora) and then startup a client that automatically does a bunch of operations
  • I can run a client (https://use-contractkit.vercel.app) and then run a wallet that automatically approves operations

Tested

cd packages/sdk/wallets/wallet-walletconnect
WALLET_CONNECT_BRIGDE=wss://relay.walletconnect.org yarn test
WALLET_CONNECT_BRIGDE=wss://walletconnect.celo-networks-dev.org yarn test

@AlexBHarley AlexBHarley requested a review from eruizgar91 March 23, 2021 16:06
@carterqw2 carterqw2 mentioned this pull request Mar 23, 2021
Closed
eelanagaraj
eelanagaraj approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@eelanagaraj eelanagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, cool regarding the testing flows!

@AlexBHarley AlexBHarley added the automerge Have PR merge automatically when checks pass label Mar 23, 2021
@AlexBHarley AlexBHarley removed the automerge Have PR merge automatically when checks pass label Mar 23, 2021
@AlexBHarley AlexBHarley changed the title fix: small fixes for WalletConnect alpha.31 fix: small fixes for WalletConnect alpha.32 Mar 25, 2021
@AlexBHarley AlexBHarley added the automerge Have PR merge automatically when checks pass label Mar 25, 2021
@mergify mergify bot merged commit fe6e010 into master Mar 25, 2021
@mergify mergify bot deleted the alexbharley/wallet-connect-alpha.31 branch March 25, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eelanagaraj eelanagaraj eelanagaraj approved these changes

@eruizgar91 eruizgar91 Awaiting requested review from eruizgar91

@barbaraliau barbaraliau Awaiting requested review from barbaraliau

@gastonponti gastonponti Awaiting requested review from gastonponti

@medhakothari medhakothari Awaiting requested review from medhakothari

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexBHarley @eelanagaraj