Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packages vulnerabilities #7476

Merged
merged 15 commits into from
Mar 19, 2021
Merged

Fix packages vulnerabilities #7476

merged 15 commits into from
Mar 19, 2021

Conversation

gastonponti
Copy link
Contributor

@gastonponti gastonponti commented Mar 18, 2021 •
edited
Loading

Description

Fix multiple vulnerabilities

Other changes

Fix the circle ci check from npmjs
Fix google cloud build
Updates web3 -> 1.3.4

@gastonponti gastonponti requested a review from a team March 18, 2021 23:44
@gastonponti gastonponti requested a review from a team as a code owner March 18, 2021 23:44
@gastonponti gastonponti force-pushed the gastonponti/packages-vulnerabilities branch from 839ba25 to 497604d Compare March 19, 2021 00:15
barbaraliau
barbaraliau approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@barbaraliau barbaraliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments but this is good if the version numbers are the right ones.

packages/faucet/package.json Show resolved Hide resolved
packages/phone-number-privacy/common/package.json Show resolved Hide resolved
barbaraliau
barbaraliau approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@barbaraliau barbaraliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comment

packages/phone-number-privacy/signer/package.json Show resolved Hide resolved
@gastonponti gastonponti changed the title Gastonponti/packages vulnerabilities Fix packages vulnerabilities Mar 19, 2021
@barbaraliau barbaraliau merged commit f69c9f8 into master Mar 19, 2021
@barbaraliau barbaraliau deleted the gastonponti/packages-vulnerabilities branch March 19, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaraliau barbaraliau barbaraliau approved these changes

@asaj asaj Awaiting requested review from asaj

@cmcewen cmcewen Awaiting requested review from cmcewen

@mcortesi mcortesi Awaiting requested review from mcortesi

@medhakothari medhakothari Awaiting requested review from medhakothari

@timmoreton timmoreton Awaiting requested review from timmoreton

@eelanagaraj eelanagaraj Awaiting requested review from eelanagaraj

Assignees
No one assigned
Labels
Applications Applications circle tasks Component: ContractKit Component: SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastonponti @barbaraliau