Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dappkit dependency on expo #7286

Closed
wants to merge 4 commits into from

Conversation

AlexBHarley
Copy link
Contributor

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@barbaraliau barbaraliau removed the request for review from mcortesi February 26, 2021 17:57
@AlexBHarley AlexBHarley changed the base branch from master to devx/update-dappkit February 26, 2021 18:08
@barbaraliau barbaraliau added the Applications Applications circle tasks label Feb 26, 2021
Copy link
Contributor

@barbaraliau barbaraliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Expo also needs to be removed from package.json and react-native added in

@eelanagaraj
Copy link
Contributor

will close this PR once #7328 is merged, as that required this PR's changes!

@eelanagaraj eelanagaraj closed this Mar 9, 2021
@aaronmgdr aaronmgdr deleted the alexbharley/dappkit-expo branch August 16, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Applications circle tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants