Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallets-test #7094

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Fix wallets-test #7094

merged 3 commits into from
Feb 12, 2021

Conversation

AlexBHarley
Copy link
Contributor

@AlexBHarley AlexBHarley commented Feb 12, 2021

Description

Tried to fix this previously but no dice. This fix pins the secp256k1 version for our aws-hsm-wallet package.

@AlexBHarley AlexBHarley requested a review from nategraf February 12, 2021 10:51
@AlexBHarley AlexBHarley added the automerge Have PR merge automatically when checks pass label Feb 12, 2021
@eelanagaraj
Copy link
Contributor

@AlexBHarley looks good -- out of curiosity, do we know which nested dependency was causing the issue that's resolved by the change?

@AlexBHarley
Copy link
Contributor Author

@eelanagaraj ethereumjs-util and hdkey

@mergify mergify bot merged commit ffcf304 into master Feb 12, 2021
@mergify mergify bot deleted the alexbharley/secp256k1-fix branch February 12, 2021 17:37
alecps pushed a commit that referenced this pull request Feb 17, 2021
### Description

Tried to fix this [previously](#6432) but no dice. This fix pins the `secp256k1` version for our `aws-hsm-wallet` package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants