Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N02] Function behaves as modifier #6988

Merged
merged 6 commits into from
Feb 16, 2021
Merged

[N02] Function behaves as modifier #6988

merged 6 commits into from
Feb 16, 2021

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Feb 9, 2021 •
edited
Loading

Description

isAllowedToSpendExchange turned into a modifier.

Other changes

Tested

Test were already written and they pass.

Related issues

Backwards compatibility

  • No changed in behavior

@martinvol martinvol requested a review from a team February 9, 2021 12:51
@martinvol martinvol changed the base branch from master to release/celo-core-contracts/3 February 9, 2021 12:51
AlexBHarley
AlexBHarley reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@AlexBHarley AlexBHarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

m-chrzan
m-chrzan approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@m-chrzan m-chrzan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@martinvol martinvol changed the title isAllowedToSpendExchange made a modifier modifier [N02] Function behaves as modifier Feb 10, 2021
@martinvol martinvol added automerge Have PR merge automatically when checks pass and removed automerge Have PR merge automatically when checks pass labels Feb 10, 2021
@martinvol martinvol added the automerge Have PR merge automatically when checks pass label Feb 16, 2021
@martinvol martinvol merged commit 1372c5c into release/celo-core-contracts/3 Feb 16, 2021
@martinvol martinvol deleted the martinvol/isAllowedToSpendExchange_modifier branch February 16, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexBHarley AlexBHarley AlexBHarley left review comments

@m-chrzan m-chrzan m-chrzan approved these changes

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvol @AlexBHarley @m-chrzan