[Wallet] Update Account Key backup prompt #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2020 03:31
etuleu
reviewed
Nov 24, 2020
packages/mobile/src/app/actions.ts
Outdated
| @@ -84,6 +75,11 @@ interface InviteModalAction { | |||
| inviteModalVisible: boolean | |||
| } | |||
|
|
|||
| interface ActiveScreenChangedAction { | |||
| type: Actions.ACTIVE_SCREEN_CHANGED | |||
| activeScreen: string | |||
There was a problem hiding this comment.
can we use the Screens enum here?
jeanregisser
suggested changes
Nov 25, 2020
| @@ -3,6 +3,8 @@ | |||
| "introTitle": "Your Account Key", | |||
| "introBody": "Your Account Key is the most important part of your account.\n\nPlease find a private place to set up your key. It takes about five minutes.", | |||
| "introPrimaryAction": "Set Up Now", | |||
| "backupSetupTitle": "Set Up Your Account Key", | |||
| "backupSetupBody": "To protect your funds, you're required to set up your Account Key before you can continue using Valora.", | |||
There was a problem hiding this comment.
Suggested change
| "backupSetupBody": "To protect your funds, you're required to set up your Account Key before you can continue using Valora.", | |
| "backupSetupBody": "To protect your funds, you're required to set up your Account Key before you can continue using {{appName}}.", |
| @@ -3,6 +3,8 @@ | |||
| "introTitle": "La Clave de Cuenta", | |||
| "introBody": "La clave de tu cuenta es la parte más importante de tu cuenta. Configurarla toma cinco minutos", | |||
| "introPrimaryAction": "Configurar Ahora", | |||
| "backupSetupTitle": "Configura Tu Clave De Cuenta", | |||
| "backupSetupBody": "Para proteger tus fondos, debes configurar tu Clave de Cuenta antes de poder continuar usando Valora.", | |||
There was a problem hiding this comment.
Suggested change
| "backupSetupBody": "Para proteger tus fondos, debes configurar tu Clave de Cuenta antes de poder continuar usando Valora.", | |
| "backupSetupBody": "Para proteger tus fondos, debes configurar tu Clave de Cuenta antes de poder continuar usando {{appName}}.", |
| const styles = StyleSheet.create({ | ||
| container: { | ||
| flex: 1, | ||
| flexDirection: 'column', |
There was a problem hiding this comment.
nit: this is the default already.
Suggested change
| flexDirection: 'column', |
There was a problem hiding this comment.
Yeah, I know. I just always put the direction when it's important because it helps imo to have that sort of things explicit, but I can see how one might think it's unnecessary. Removed.
There was a problem hiding this comment.
Yes no worry, fine to keep it too 👍
added 2 commits
November 25, 2020 15:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the backup prompt for a full screen thing following the design on Figma
Tested
Manually on iOS and Android
Related issues