Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix decimals keyboard in some Samsung devices #5926

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

gnardini
Copy link
Contributor

Description

On some Samsung devices, the numpad when inputting decimal amounts was not showing the decimal separator (dot or comma).

This is because these Samsung devices apparently have the same value for the decimal pad constant than for the autocapitalize constant, which causes them to override each other (🤦 ).

Tested

On a Samsung device:

Before:
Screenshot_2020-11-20-13-31-32

After:
Screenshot_2020-11-20-13-31-23

Related issues

Backwards compatibility

N/A

Copy link
Contributor

@etuleu etuleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gnardini gnardini added the automerge Have PR merge automatically when checks pass label Nov 24, 2020
@mergify mergify bot merged commit a2cf49d into master Nov 25, 2020
@mergify mergify bot deleted the decimals-android branch November 25, 2020 05:57
@ValoraQA
Copy link

Hey @gnardini I have verified this issue using Android internal build V1.15.1 & Test Flight build V1.15.1 & observed following:
Observations:

  • It is observed that issue is fixed now. User is able to enter decimal value while Sending/Requesting money.
    Attachment: AbleToEnterDecimalValue.mp4
    Verified On Devices: Samsung Galaxy S4 (4.4.2), Samsung Galaxy S4 (5.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
3 participants