[Wallet] Changes to Simplex cash in #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
approved these changes
Nov 12, 2020
|
Still working on getting iOS tests passing |
i1skn
pushed a commit
that referenced
this pull request
Nov 13, 2020
### Description Implement the changes discussed in this thread: https://celo-org.slack.com/archives/CL7BVQPHB/p1605212144230400 - Open Simplex webpage instead of using a webview. - Selection: right now, seems like the selection for cUSD/CELO is dependent on the method selected vs the country (eg CELO should always be selectable, but then only provide the option for ‘cryptocurrency exchange’ - Debit Card copy change-- update “Debit, Credit, or Bank Account” to “Debit Card or Bank Account” ### Tested Manually
|
Hi @tarikbellamine i Have verified this issue latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5 (1004294323) and observe the following
Devices: iPhone 6+ (12.4.5) , Vivo v11 pro (10) Can you please let us know if we need to test anything else in this task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the changes discussed in this thread: https://celo-org.slack.com/archives/CL7BVQPHB/p1605212144230400
Tested
Manually