[Wallet] Retry if geth fails to init because of no internet #5700
Conversation
| let restartAppAutomatically: boolean = false | ||
| let errorContext: string | ||
|
|
||
| switch (failureResult) { | ||
| case GethInitOutcomes.NETWORK_ERROR_FETCHING_GENESIS_BLOCK: { |
There was a problem hiding this comment.
Looks like we'd have a similar issue when fetching the genesis block on the first app launch if the network is down.
Right?
There was a problem hiding this comment.
Yes, exactly! also the other remaining case is geth timeout. I wanted to discuss with you possible ways to recover from those. I tried using the same code path for those errors as well but we run into multiple geth inits happening at the same time. We need a clean way to cancel before we init a new one.
Or, if geth itself has any sort of timeouts, we need to make our own timeouts at least as large as those, so that when we retry we know that the previous one stopped trying. Does that make sense? I would love to hear your thoughts and what we've already tried in the past.
There was a problem hiding this comment.
Yes let's continue the discussion. Can you open an issue so we can address these edge cases in a separate PR? 🙏
|
@etuleu @jeanregisser Verified with Test flight build v1.4.0 (28) and Android play store (internal build) v1.4.0 (1004294317) while doing testing on mentioned build we have observed Oops something went wrong screen on one time on a Friday after that we have not observed such screen. Also, tried with give steps but did not observed the oops screen.
Actual result of above steps:
However, we will update the ticket if we faced Oops screen again any time. FYI, Informed this issue here as an observation as facing issue randomly |
|
@etuleu Just observed oops screen but not with exact give steps.
Build: Android play store (internal build) v1.4.0 (1004294317) |
|
Thank you for testing this Ankit! From the logs I don't see a crash or anything like that. Did you turn the internet connection back on at some point? |
|
Hi @etuleu Yes, I did not observed any crash but observed Oops screen when launching the app without internet connection. |
Description
We explicitly crash the app if geth fails to initialize on startup. There are a few different cases how that can happen but one way to cause it is to start the app in airplane mode. This causes a network failure which immediately sends the user to the "Oops" screen.
The fix is to implement a retry. Of course this can go on forever if the network connection never comes back, so we could implement a limited number of retries. I don't think that is a good design though as we should never see the Oops screen or intentionally kill the app. Instead we should provide hints to the user as to how they might fix it. In this case we do have a Connecting banner, but we could do more such as showing a popup maybe. In general it is hard to tell why the app cannot connect. For example there might be a port block and the network is fine otherwise. I have some ideas here, such as using google firebase to check network connectivity, but that's for another time.
Other changes
There are other geth failure modes such as when the timeout hits. This is a bit trickier to fix because we would need to cancel the initial init and start a new one. I will leave that for another PR after discussing with @jeanregisser how to implement that.
Tested
Steps to reproduce on simulator or real device (TODO: write an e2e test):
Related issues
Backwards compatibility
Yes.