Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeanregisser/xcode12 #5686

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Jeanregisser/xcode12 #5686

merged 3 commits into from
Nov 3, 2020

Conversation

jeanregisser
Copy link
Contributor

@jeanregisser jeanregisser commented Nov 3, 2020

Description

Follow up on #5670

I initially thought removing the -sdk iphonesimulator was the right fix but it caused issues on the CI.

Xcode 12 now tries to build both arm64 and x86_64 slices for the simulator
See:

Also upgrade CocoaPods

And use Xcode 12.1.0 on CircleCI

Tested

Successfully ran:

  • yarn test:e2e:ios (Debug)
  • yarn test:e2e:ios -r (Release)

Also successful build targeting the Simulator directly within Xcode.

@cmcewen cmcewen merged commit ff34c30 into cmcewen/xcode12 Nov 3, 2020
@aaronmgdr aaronmgdr deleted the jeanregisser/xcode12 branch August 16, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants