[Wallet] Prompt users with connectivity issues to switch to forno #2526

annakaz · 2020-01-23T23:19:28Z

Description

When geth is taking too long to sync (>15 seconds for web3 to sync or seeing connectivity issues with geth), prompt them to turn on forno. Do not prompt if users have already declined to avoid an instrusive experience, and wait to prompt until after they have gone through the welcome screen

Tested

On a pixel 2 by changing sync to take too long and confirming that users are prompted to switch to forno

Other changes

Cancel geth sagas when switching to forno rather than checking within sagas whether forno is enabled

Related issues

Fixes Users SBAT be prompted to switch to forno when experiencing connectivity issues #1559

Backwards compatibility

Yes

jmrossy · 2020-01-24T17:24:41Z

packages/mobile/locales/es-419/accountScreen10.json

+  "promptZeroSyncModal": {
+    "header": "Cambiar modo de conexión?",
+    "body": "Hemos notado que tienes problemas para conectarte. Recomendamos habilitar el modo de ahorro de datos para que pueda seguir usando Celo Wallet con una conexión intermitente.",
+    "switchToDataSaver": "Habilitar Data Saver"


Once #2539 merges please use Ahorro de Datos here

Updated translation

jmrossy · 2020-01-24T17:27:49Z

packages/mobile/src/geth/actions.ts

+  type: Actions.CANCEL_GETH_SAGA,
+})
+
+interface SetPromptZeroSync {


Nit, I think the name convention we use elsewhere is SetPromptZeroSyncAction, though I guess not in this file for some reason

Updated all actions in this file to use the normal naming convention

jmrossy · 2020-01-24T17:32:31Z

packages/mobile/src/geth/saga.ts

+    // Suggest switch to forno for network-related errors
+    if (yield select(promptZeroSyncIfNeededSelector)) {
+      yield put(setPromptZeroSync(false))
+      navigate(Screens.DataSaver, { promptModalVisible: true })


I assumed we would just enable forno silently in this case. @nityas can you confirm that navigating the user to the Data Saver screen is the desired behavior?

The user gets navigated to the DataSaver screen with a modal, then once they confirm/decline the switch they go back to wherever they were

Confirmed with @nityas that this prompt is the expected behavior!

confirmed-- it adds a layer of centralization and we do not want to do this without user consent

packages/mobile/src/invite/JoinCelo.tsx

packages/mobile/src/geth/selectors.ts

…epo into annakaz/prompt-forno

codecov · 2020-01-24T19:43:39Z

Codecov Report

Merging #2526 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #2526    +/-   ##
========================================
  Coverage   73.24%   73.24%            
========================================
  Files         556      556            
  Lines       13824    13824            
  Branches     1722     1425   -297     
========================================
  Hits        10125    10125            
  Misses       3418     3418            
  Partials      281      281

Flag	Coverage Δ
#mobile	`74.1% <ø> (ø)`	⬆️
#web	`72.02% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
packages/mobile/test/schemas.ts	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c5cfc...1311a2e. Read the comment docs.

jmrossy · 2020-01-24T20:55:39Z

packages/mobile/src/geth/saga.ts

-  yield fork(monitorGeth)
+  const gethRelatedSagas = yield all([fork(monitorAppState), fork(monitorGeth)])
+  yield take(Actions.CANCEL_GETH_SAGA)
+  yield cancel(gethRelatedSagas)


Can you confirm this cancels the individual forks and not just the synthesized one created by all()? If monitorGeth's logs no longer show up after cancel that would confirm it :)

Yes confirmed that monitorGeth logs go away! Agree that the redux saga cancel all documentation is unclear though (https://redux-saga.js.org/docs/advanced/TaskCancellation.html / outdated post redux-saga/redux-saga#988 (comment))

jmrossy · 2020-01-24T20:58:04Z

packages/mobile/test/schemas.ts

@@ -63,6 +63,7 @@ export const vNeg1Schema = {
  geth: {
    initialized: 'INITIALIZED',
    connected: true,
+    promptZeroSyncIfNeeded: false,


state schema changes, including new additions, need to go in the latest schema (v5 below) since it didn't exist in v-1

…epo into annakaz/prompt-forno

annakaz · 2020-01-24T21:56:54Z

Note that build is failing on master due to attestation service (unrelated to this PR)

)

* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)

)

annakaz added 11 commits January 8, 2020 11:43

WIP

9a3826b

Merge branch 'master' into annakaz/prompt-forno

c45ce30

WIP cancelling geth sagas

313dd7a

Clean up forno related sagas

1e45ae4

cancel geth saga

0d815d5

Geth logic for forno prompt

d92ebd2

Switch to datasaver when necessary

261e551

Redirect to datasaver when necessary

7040ff4

Finish testing

594d767

Remove if true used for testing

b6ca93a

Remove unused comment

5be27e8

annakaz requested review from cmcewen and jmrossy as code owners January 23, 2020 23:19

Merge branch 'master' into annakaz/prompt-forno

ca6aa76

annakaz requested a review from a team January 23, 2020 23:20

jmrossy reviewed Jan 24, 2020

View reviewed changes

jmrossy assigned annakaz Jan 24, 2020

annakaz and others added 4 commits January 24, 2020 10:55

Make changes based on review

bcfb4b3

Merge branch 'annakaz/prompt-forno' of github.com:celo-org/celo-monor…

b28fc1e

…epo into annakaz/prompt-forno

Merge branch 'master' into annakaz/prompt-forno

9c4b687

Merge branch 'annakaz/prompt-forno' of github.com:celo-org/celo-monor…

76713e0

…epo into annakaz/prompt-forno

annakaz assigned jmrossy and unassigned annakaz Jan 24, 2020

Fix tests

c7c5cfc

annakaz requested a review from a team January 24, 2020 19:59

jmrossy reviewed Jan 24, 2020

View reviewed changes

jmrossy assigned annakaz and unassigned jmrossy Jan 24, 2020

Merge branch 'master' into annakaz/prompt-forno

617d42e

annakaz added 2 commits January 24, 2020 13:31

Update schema v5

d2dd3f2

Merge branch 'annakaz/prompt-forno' of github.com:celo-org/celo-monor…

1311a2e

…epo into annakaz/prompt-forno

jmrossy approved these changes Jan 24, 2020

View reviewed changes

annakaz merged commit 5c4f07e into master Jan 24, 2020

lucasege pushed a commit that referenced this pull request Jan 27, 2020

[Wallet] Prompt users with connectivity issues to switch to forno (#2526

ba96b3f

)

annakaz mentioned this pull request Jan 28, 2020

[Wallet] Clean up forno mode #2584

Merged

mcortesi deleted the annakaz/prompt-forno branch February 14, 2020 22:03

lucasege pushed a commit that referenced this pull request Jun 24, 2020

[Wallet] Prompt users with connectivity issues to switch to forno (#2526

40e0115

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wallet] Prompt users with connectivity issues to switch to forno #2526

[Wallet] Prompt users with connectivity issues to switch to forno #2526

annakaz commented Jan 23, 2020

jmrossy Jan 24, 2020

annakaz Jan 24, 2020

jmrossy Jan 24, 2020

annakaz Jan 24, 2020

jmrossy Jan 24, 2020

annakaz Jan 24, 2020

annakaz Jan 24, 2020

nityas Jan 24, 2020

codecov bot commented Jan 24, 2020 •

edited

Loading

jmrossy Jan 24, 2020

annakaz Jan 24, 2020

jmrossy Jan 24, 2020

annakaz commented Jan 24, 2020

[Wallet] Prompt users with connectivity issues to switch to forno #2526

[Wallet] Prompt users with connectivity issues to switch to forno #2526

Conversation

annakaz commented Jan 23, 2020

Description

Tested

Other changes

Related issues

Backwards compatibility

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 24, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annakaz commented Jan 24, 2020

codecov bot commented Jan 24, 2020 •

edited

Loading