Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add celo.org/about#contributors id #2488

Merged
merged 13 commits into from
Jan 22, 2020
Merged

add celo.org/about#contributors id #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a5ece84
Add react-testing-library
aaronmgdr Jan 11, 2020
5251af3
Remove Jest-dom assertions line as I never to it working
aaronmgdr Jan 11, 2020
5794b73
Add test for mobile menu
aaronmgdr Jan 12, 2020
f226ae5
Test for Team.tsx
aaronmgdr Jan 12, 2020
a43d2b2
Fix a deprecation warning about Link needing a, `a` child
aaronmgdr Jan 13, 2020
1c6dbeb
Fix racing condition of analytics track vs init.
aaronmgdr Jan 14, 2020
6444988
Remove console log
aaronmgdr Jan 14, 2020
e79868e
Handle promises
aaronmgdr Jan 14, 2020
c187248
Add contributors id for about#contributors navigation
aaronmgdr Jan 14, 2020
23c0e3a
Merge branch 'master' into aaronmgdr/contributors-id
aaronmgdr Jan 21, 2020
d56c884
Snap
aaronmgdr Jan 21, 2020
e202a43
Merge branch 'master' into aaronmgdr/contributors-id
aaronmgdr Jan 22, 2020
1281434
Merge refs/heads/master into aaronmgdr/contributors-id
Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
247 changes: 126 additions & 121 deletions packages/web/src/_page-tests/__snapshots__/about.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,142 +1968,119 @@ exports[`About renders 1`] = `
</div>
<div
className="css-view-1dbjc4n"
style={
Object {
"WebkitAlignSelf": "center",
"WebkitBoxDirection": "normal",
"WebkitBoxOrient": "vertical",
"WebkitFlexDirection": "column",
"alignSelf": "center",
"flexDirection": "column",
"marginTop": "50px",
"maxWidth": "100vw",
"msFlexDirection": "column",
"msFlexItemAlign": "center",
"paddingLeft": "10px",
"paddingRight": "10px",
"width": "100%",
}
}
id="contributors"
>
<div
className="css-view-1dbjc4n"
style={
Object {
"WebkitBoxFlex": 0,
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"flexGrow": 0,
"flexShrink": 0,
"msFlexNegative": 0,
"msFlexPositive": 0,
"paddingBottom": "10px",
"WebkitAlignSelf": "center",
"WebkitBoxDirection": "normal",
"WebkitBoxOrient": "vertical",
"WebkitFlexDirection": "column",
"alignSelf": "center",
"flexDirection": "column",
"marginTop": "50px",
"maxWidth": "100vw",
"msFlexDirection": "column",
"msFlexItemAlign": "center",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
>
<h3
aria-level="3"
className="css-reset-4rbku5 css-text-901oao"
dir="auto"
role="heading"
<div
className="css-view-1dbjc4n"
style={
Object {
"color": "rgba(46,51,56,1.00)",
"fontFamily": "Jost, futura-pt, futura, sans-serif",
"fontSize": "24px",
"lineHeight": "32px",
"textRendering": "geometricPrecision",
"textTransform": "none",
"WebkitBoxFlex": 0,
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"flexGrow": 0,
"flexShrink": 0,
"msFlexNegative": 0,
"msFlexPositive": 0,
"paddingBottom": "10px",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
>
teamTitle
</h3>
</div>
<div
className="css-view-1dbjc4n"
style={
Object {
"WebkitBoxFlex": 0,
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"flexGrow": 0,
"flexShrink": 0,
"msFlexNegative": 0,
"msFlexPositive": 0,
"paddingBottom": "10px",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
>
<h3
aria-level="3"
className="css-reset-4rbku5 css-text-901oao"
dir="auto"
role="heading"
style={
Object {
"color": "rgba(46,51,56,1.00)",
"fontFamily": "Jost, futura-pt, futura, sans-serif",
"fontSize": "24px",
"lineHeight": "32px",
"textRendering": "geometricPrecision",
"textTransform": "none",
}
}
>
teamTitle
</h3>
</div>
<div
className="css-text-901oao"
dir="auto"
className="css-view-1dbjc4n"
style={
Object {
"color": "rgba(46,51,56,1.00)",
"fontFamily": "EB Garamond, eb-garamond, Garamond, serif",
"fontSize": "20px",
"lineHeight": "28px",
"marginBottom": "50px",
"textRendering": "geometricPrecision",
"WebkitBoxFlex": 0,
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"flexGrow": 0,
"flexShrink": 0,
"msFlexNegative": 0,
"msFlexPositive": 0,
"paddingBottom": "10px",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
>
teamCopy

<div
className="css-text-901oao"
dir="auto"
style={
Object {
"color": "rgba(46,51,56,1.00)",
"fontFamily": "EB Garamond, eb-garamond, Garamond, serif",
"fontSize": "20px",
"lineHeight": "28px",
"marginBottom": "50px",
"textRendering": "geometricPrecision",
}
}
>
teamCopy

</div>
</div>
</div>
</div>
<div
className="css-view-1dbjc4n"
style={
Object {
"WebkitAlignSelf": "center",
"WebkitBoxDirection": "normal",
"WebkitBoxOrient": "vertical",
"WebkitFlexDirection": "column",
"alignSelf": "center",
"flexDirection": "column",
"maxWidth": "100vw",
"msFlexDirection": "column",
"msFlexItemAlign": "center",
"paddingLeft": "10px",
"paddingRight": "10px",
"width": "100%",
}
}
>
<div
className="css-view-1dbjc4n"
style={
Object {
"WebkitAlignItems": "center",
"WebkitBoxAlign": "center",
"WebkitBoxFlex": 0,
"WebkitBoxPack": "center",
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"WebkitJustifyContent": "center",
"alignItems": "center",
"flexGrow": 0,
"flexShrink": 0,
"justifyContent": "center",
"msFlexAlign": "center",
"msFlexNegative": 0,
"msFlexPack": "center",
"msFlexPositive": 0,
"paddingBottom": "10px",
"WebkitAlignSelf": "center",
"WebkitBoxDirection": "normal",
"WebkitBoxOrient": "vertical",
"WebkitFlexDirection": "column",
"alignSelf": "center",
"flexDirection": "column",
"maxWidth": "100vw",
"msFlexDirection": "column",
"msFlexItemAlign": "center",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
Expand All @@ -2112,35 +2089,63 @@ exports[`About renders 1`] = `
className="css-view-1dbjc4n"
style={
Object {
"display": "grid",
"gridColumnGap": "40px",
"gridRowGap": "55px",
"gridTemplateColumns": "repeat(3, 1fr)",
"minHeight": "50vh",
"msGridColumnGap": "40px",
"msGridRowGap": "55px",
"msGridTemplateColumns": "repeat(3, 1fr)",
"WebkitAlignItems": "center",
"WebkitBoxAlign": "center",
"WebkitBoxFlex": 0,
"WebkitBoxPack": "center",
"WebkitFlexGrow": 0,
"WebkitFlexShrink": 0,
"WebkitJustifyContent": "center",
"alignItems": "center",
"flexGrow": 0,
"flexShrink": 0,
"justifyContent": "center",
"msFlexAlign": "center",
"msFlexNegative": 0,
"msFlexPack": "center",
"msFlexPositive": 0,
"paddingBottom": "10px",
"paddingLeft": "10px",
"paddingRight": "10px",
"paddingTop": "10px",
"width": "100%",
}
}
>
<div
aria-label="loading"
className="css-view-1dbjc4n"
style={
Object {
"height": "50px",
"width": "50px",
"display": "grid",
"gridColumnGap": "40px",
"gridRowGap": "55px",
"gridTemplateColumns": "repeat(3, 1fr)",
"minHeight": "50vh",
"msGridColumnGap": "40px",
"msGridRowGap": "55px",
"msGridTemplateColumns": "repeat(3, 1fr)",
}
}
>
<span
<div
aria-label="loading"
className="css-view-1dbjc4n"
style={
Object {
"height": "100%",
"width": "100%",
"height": "50px",
"width": "50px",
}
}
/>
>
<span
style={
Object {
"height": "100%",
"width": "100%",
}
}
/>
</div>
</div>
</div>
</div>
Expand Down
10 changes: 10 additions & 0 deletions packages/web/src/about/About.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { render } from '@testing-library/react'
import * as React from 'react'
import About from 'src/about/About'

describe(About, () => {
it('includes element with #contributors id', async () => {
render(<About randomSeed={10} />)
expect(document.getElementById('contributors')).toBeTruthy()
})
})
4 changes: 2 additions & 2 deletions packages/web/src/about/Team.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class Team extends React.Component<Props & I18nProps & ScreenProps> {
const isTablet = screen === ScreenSizes.TABLET
const isMobile = screen === ScreenSizes.MOBILE
return (
<>
<View nativeID="contributors">
<BookLayout label={t('teamTitle')} startBlock={true}>
<Text style={[fonts.p, standardStyles.sectionMarginBottomMobile]}>{t('teamCopy')} </Text>
</BookLayout>
Expand Down Expand Up @@ -66,7 +66,7 @@ export class Team extends React.Component<Props & I18nProps & ScreenProps> {
</View>
</Cell>
</GridRow>
</>
</View>
)
}
}
Expand Down