[Wallet] Fix fail to sync issue #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 274 274
Lines 7803 7803
Branches 985 985
=======================================
Hits 5844 5844
Misses 1846 1846
Partials 113 113
Continue to review full report at Codecov.
|
jmrossy
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See all details in valora-inc/react-native-tcp#3
The fix itself is quite short but involved a lot of verifications to be sure it now behaves correctly 😄
Tested
Tested that the fail to sync issue doesn't occur anymore under normal conditions on iOS and Android.
Other changes
None
Related issues
Backwards compatibility
Yes.