Add issue templates and update CODEOWNERS for auto labeling and assigning - non-collaborators cant add labels or assignees #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
==========================================
- Coverage 74.87% 74.45% -0.43%
==========================================
Files 281 281
Lines 7805 7817 +12
Branches 686 685 -1
==========================================
- Hits 5844 5820 -24
- Misses 1845 1880 +35
- Partials 116 117 +1
Continue to review full report at Codecov.
|
KoenBal
commented
Dec 7, 2019
Comment on lines
+5
to
+9
| # These owners will be the default owners for everything in | ||
| # the repo. Unless a later match takes precedence, | ||
| # @XXXX will be requested for | ||
| # review when someone opens a pull request. | ||
| * @timmoreton |
There was a problem hiding this comment.
Add a default owner such that a PR always gets an assignee. Appologies to put you here :).
KoenBal
commented
Dec 7, 2019
Comment on lines
+13
to
+21
| /packages/attestation-service/ @timmoreton | ||
| /packages/blockchain-api/ @jmrossy @cmcewen | ||
| /packages/celotool/ @timmoreton | ||
| /packages/cli/ @mcortesi @asaj | ||
| /packages/contractkit/ @timmoreton | ||
| /packages/dappkit/ @timmoreton | ||
| /packages/dev-utils/ @timmoreton | ||
| /packages/docs/ @timmoreton @cla-bel | ||
| /packages/faucet/ @timmoreton |
There was a problem hiding this comment.
Added all the missing packages. Names should still be correctly assigned.
KoenBal
commented
Dec 7, 2019
Comment on lines
+19
to
+20
| /packages/dev-utils/ @timmoreton | ||
| /packages/docs/ @timmoreton @cla-bel |
There was a problem hiding this comment.
Should docs be subdivided? Any suggestions?
…gning - non-collaborators cant add labels or assignees
KoenBal
commented
Dec 7, 2019
Comment on lines
+5
to
+6
| labels: cli | ||
| assignees: mcortesi, asaj |
There was a problem hiding this comment.
Syntax for multiple assignees should be tested. This could not be tested in own repo because users are not available.
This was referenced Dec 7, 2019
|
Closing as this is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behavior
Non-collaborators (non repo members) SBAT assign labels and an assignee.
A non-collaborator (NC) is someone who is not added as a collaborator under settings on the project.
Current Behavior
An NC can't add labels or assignee to issues or PRs.
Confirmed in help:
Anyone with read access to a repository can view and search the repository’s labels. To create, edit, apply, or delete a label, you must have write access to the repository.
personal note: I (a new repo contributor) am not certain which label to assign or am not comfortable to push my issue in someone's bucket if I'm not sure if he/she is working on part X of the project or I don't know her/him.
Ideas:
All guidance is welcome for newcomers. Auto assigning assignees and labels would be the way to go.
a possible solution for issues:
issue templates for your repo
Other ideas (not further explored)
Use a issue actions?
A possible solution adding assignees to PRs:
The CODEOWNERS file (which is already implemented).
Updated such that each PR will receive a reviewer from now on. Code owners for each package should be checked though.
Note that PRs do not get labels assigned! This could be done using actions.
Other ideas (not further explored)
A Probot app that adds reviewers to pull requests when pull requests are opened
Monorepo PR repo labeler
Other PR actions?
@timmoreton @asaj