[wallet] UX fixes for native phone number #1717
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 277 277
Lines 7617 7617
Branches 669 669
=======================================
Hits 5657 5657
Misses 1845 1845
Partials 115 115
Continue to review full report at Codecov.
|
|
Removing automerge, see @annakaz 's comment |
…rg/celo-monorepo into martinvol/fix_error_native_picker
bcffaaf to
57c2b72
Compare
|
Thanks to @jeanregisser I figured out a way to differentiate USA vs Canada and should be working fine now. |
| } catch (error) { | ||
| console.info( | ||
| `${TAG}/triggerPhoneNumberRequestAndroid`, | ||
| 'Could not request phone. This might be thrown if the user dismissed the modal', |
There was a problem hiding this comment.
Can you differentiate the case when the user dismissed the modal based on the error message thrown by the NativePicker?
There was a problem hiding this comment.
Unfortunately when the modal is dismissed SmsRetriever.requestPhoneNumber() throws a generic There was an error trying to get the phone number error :/
…nvol/fix_error_native_picker
|
Should be good to go! @annakaz |
| } | ||
|
|
||
| onChangeCountryQuery = (countryQuery: string) => { | ||
| ChangeCountryQuery = (countryQuery: string) => { |
There was a problem hiding this comment.
nit: changeCountryQuery no caps?
| // linter doesn't allow following code without splitting this code in two lines | ||
| const number = await SmsRetriever.requestPhoneNumber() | ||
| return number | ||
| async _getPhoneNumberFromNativePickerAndroid() { |
There was a problem hiding this comment.
Haven't seen the _ used in other parts of our codebase, ok to just keep as getPhoneNumberFromNativePickerAndroid?
…rg/celo-monorepo into martinvol/fix_error_native_picker
Description
errortoinfoto prevent red screen when user dismiss the modalTested
Other changes
Related issues
Backwards compatibility