Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove consistently failing integration sync test #1487

Closed
wants to merge 1 commit into from

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Oct 25, 2019

Description

Removes an end-to-end test that we no longer rely on. This test fails consistently which habituates us to failing master builds, which can hide underlying real issues.

Tested

These are tests

Other changes

None

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, the test is still failing?

@nambrot nambrot assigned asaj and unassigned nambrot Oct 26, 2019
@nategraf
Copy link
Contributor

So I actually know why this test is failing (the alfrajoresstaging environment was deployed with a different epoch size than exists in the .env.alfajorestaging file at master) at the moment and am working on a fix. If I do fix it, would it be worth reinstating or has it been historically unreliable?

@nategraf
Copy link
Contributor

I've created #1504 to address the standing issue with this test if we want to keep it.

@nategraf
Copy link
Contributor

We decided to go with #1504 to fix the test rather than nixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants