Setup oracle account, Add CLI commands to report oracle values #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from reporting again.
… values accessible to tests
…onfig value defined
nambrot
reviewed
Nov 4, 2019
| const sortedOracles = await this.kit.contracts.getSortedOracles() | ||
|
|
||
| const rates = await sortedOracles.getRates(res.args.token) | ||
| console.log( |
There was a problem hiding this comment.
Optional: You might want to use cli.table that we use in other cli commands as well
There was a problem hiding this comment.
oh cool! I didn't know about it until now and it's great!
| numerator = numerator.multipliedBy(multiplier) | ||
| denominator = denominator.multipliedBy(multiplier) | ||
| } | ||
| // const numerator = price.multipliedBy(denominator).toNumber() |
| const res = this.parse(ReportPrice) | ||
| let token: CeloToken | ||
| if (res.flags.token === CeloContract.StableToken) { | ||
| token = CeloContract.StableToken |
There was a problem hiding this comment.
Does token have to be set if res.flags.token is equal to StableToken? Alternatively, you could set the options option on the flag to require token to be member of a set
| async run() { | ||
| const supportedTokens: CeloToken[] = [CeloContract.StableToken] | ||
| const res = this.parse(GetRates) | ||
| if (!supportedTokens.includes(res.args.token)) { |
There was a problem hiding this comment.
You can use the options option of the argument to ensure that token is in a specific set
…rever when you try to locally sign things
|
I split this up into multiple PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new account type that can have its private key and account address derived from the mnemonic. This price oracle account gets funded in the genesis block to cover the fees of its transactions.
The other component of this PR is two new CLI commands. One of them reports the exchange rate between a specified token (currently just
StableToken) andCeloGold. The other gets the currently reported rates. This one I added to easily check if the reporting was working, and figured it might be useful enough to keep.Tested
The oracle account's inclusion in the genesis block and ability to act as an oracle was tested manually by spinning up a testnet and running the added CLI commands. Report transactions sent from the oracle account were successful and ones sent from other accounts were not.
Other changes
In the code-comments documentation for
SortedOracles.report, thedenominatorparam was missing. I added an explanation of what it is.Related issues