Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Footer #1331

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Update Footer #1331

merged 4 commits into from
Oct 21, 2019

Conversation

aaronmgdr
Copy link
Member

Description

adds link to Terms page (which also links to privacy policy and other important pages)

adds discord to the footer

Other changes

add missing style to inline button props

Related issues

https://github.com/celo-org/celo-labs/issues/150
https://github.com/celo-org/celo-labs/issues/142
https://github.com/celo-org/celo-labs/issues/145

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #1331 into master will decrease coverage by 5.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1331      +/-   ##
=========================================
- Coverage   72.38%   67.1%   -5.29%     
=========================================
  Files         298     266      -32     
  Lines       10042    7776    -2266     
  Branches      701     444     -257     
=========================================
- Hits         7269    5218    -2051     
+ Misses       2673    2458     -215     
  Partials      100     100
Flag Coverage Δ
#mobile 67.1% <ø> (ø) ⬆️
#protocol ?
Impacted Files Coverage Δ
...kages/protocol/contracts/identity/Attestations.sol
.../common/linkedlists/SortedLinkedListWithMedian.sol
...ackages/protocol/contracts/common/FractionUtil.sol
.../contracts/common/linkedlists/SortedLinkedList.sol
...ackages/protocol/contracts/governance/Election.sol
...kages/protocol/contracts/stability/StableToken.sol
...ckages/protocol/contracts/common/UsingRegistry.sol
packages/protocol/contracts/common/Registry.sol
...kages/protocol/contracts/governance/Governance.sol
...ocol/contracts/common/ExtractFunctionSignature.sol
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7db19...6065139. Read the comment docs.

@aaronmgdr aaronmgdr merged commit 3805194 into master Oct 21, 2019
@aaronmgdr aaronmgdr deleted the aaronmgdr/footer-terms branch October 21, 2019 22:59
aaronmgdr added a commit that referenced this pull request Oct 23, 2019
* master: (37 commits)
  [Wallet] Add support for social wallet (Safeguards) import  (#1414)
  [Wallet] Implement new backup flows including social backup (#1399)
  Use validator set precompiles in Attestations (#1248)
  E2E Attestations test + various e2e improvements (#1417)
  Update Footer (#1331)
  [Wallet] New camera permission flow (#1398)
  [Wallet] Enable push notifications on iOS (#1389)
  [Wallet] Add Celo Lite toggle (UI only, zeroSync on/off in other PR) (#1369)
  Document npm inter-repo dependencies instructions (#1370)
  [wallet]Add more documentation on ZeroSync mode (#1367)
  [wallet]Add documentation for jndcrash (#1364)
  Point end-to-end tests back to master (#1372)
  Alfajores changes & comment on unlocking accounts (#1297)
  Reconfigure terraform local configuration during init to allow multiple envs (#773)
  Implement proof-of-stake changes (#1177)
  [Celotool] Update blockchain-api deploy script to automatically update faucet address (#1347)
  Allow most recently reporting oracle to report again (#1288)
  [wallet]Add documentation for ZeroSync mode (#1361)
  Fix Metadata registration during contract deploy (#1346)
  [Wallet] Enable firebase on iOS (#1344)
  ...
aaronmgdr added a commit that referenced this pull request Oct 23, 2019
* master: (128 commits)
  [Wallet] Add support for social wallet (Safeguards) import  (#1414)
  [Wallet] Implement new backup flows including social backup (#1399)
  Use validator set precompiles in Attestations (#1248)
  E2E Attestations test + various e2e improvements (#1417)
  Update Footer (#1331)
  [Wallet] New camera permission flow (#1398)
  [Wallet] Enable push notifications on iOS (#1389)
  [Wallet] Add Celo Lite toggle (UI only, zeroSync on/off in other PR) (#1369)
  Document npm inter-repo dependencies instructions (#1370)
  [wallet]Add more documentation on ZeroSync mode (#1367)
  [wallet]Add documentation for jndcrash (#1364)
  Point end-to-end tests back to master (#1372)
  Alfajores changes & comment on unlocking accounts (#1297)
  Reconfigure terraform local configuration during init to allow multiple envs (#773)
  Implement proof-of-stake changes (#1177)
  [Celotool] Update blockchain-api deploy script to automatically update faucet address (#1347)
  Allow most recently reporting oracle to report again (#1288)
  [wallet]Add documentation for ZeroSync mode (#1361)
  Fix Metadata registration during contract deploy (#1346)
  [Wallet] Enable firebase on iOS (#1344)
  ...
aaronmgdr added a commit that referenced this pull request Oct 23, 2019
* master: (37 commits)
  [Wallet] Add support for social wallet (Safeguards) import  (#1414)
  [Wallet] Implement new backup flows including social backup (#1399)
  Use validator set precompiles in Attestations (#1248)
  E2E Attestations test + various e2e improvements (#1417)
  Update Footer (#1331)
  [Wallet] New camera permission flow (#1398)
  [Wallet] Enable push notifications on iOS (#1389)
  [Wallet] Add Celo Lite toggle (UI only, zeroSync on/off in other PR) (#1369)
  Document npm inter-repo dependencies instructions (#1370)
  [wallet]Add more documentation on ZeroSync mode (#1367)
  [wallet]Add documentation for jndcrash (#1364)
  Point end-to-end tests back to master (#1372)
  Alfajores changes & comment on unlocking accounts (#1297)
  Reconfigure terraform local configuration during init to allow multiple envs (#773)
  Implement proof-of-stake changes (#1177)
  [Celotool] Update blockchain-api deploy script to automatically update faucet address (#1347)
  Allow most recently reporting oracle to report again (#1288)
  [wallet]Add documentation for ZeroSync mode (#1361)
  Fix Metadata registration during contract deploy (#1346)
  [Wallet] Enable firebase on iOS (#1344)
  ...
tkporter pushed a commit that referenced this pull request Oct 24, 2019
* Add link to “terms” page on the footer

* Add Discord to universal footer

* Lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants