Revert "Feature #909 proxy delegatecall" #1241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1152
This seems to have broken the end-to-end tests, which due to a yet-to-be-found bug in the incremental testing code, did not run when this PR was submitted.
The specific issue arises when trying to submit transactions before the registry implementation is deployed.
GetRegisteredAddressWithEvm
returnsevm: execution reverted
rather thanerrors.ErrRegistryContractNotDeployed
orerrors.ErrSmartContractNotDeployed
, because there is no code at the implementation address, which, with the changes in this PR, cause the call to fail.https://github.com/celo-org/celo-blockchain/blob/master/core/vm/dynamic_params.go#L46
This causes us to fail to fetch the gas price minimum in
tx_pool.go
, and we reject the transaction.https://github.com/celo-org/celo-blockchain/blob/master/core/tx_pool.go#L674
I recommend we first find and fix the bug in incremental testing, and then resubmit this PR along with an accompanying celo-blockchain PR that returns a different error when the call in
GetRegisteredAddressWithEvm
reverts, or possibly use a different proxy for the registry that doesn't include this check.