Soloseng/update-celo-L2-distribution-logic #11045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
approved these changes
Jun 21, 2024
aaronmgdr
reviewed
Jun 24, 2024
| function setGoldTokenMintingScheduleAddress(address goldTokenMintingScheduleAddress) external; | ||
| function setCeloTokenDistributionScheduleAddress( | ||
| address celoTokenDistributionScheduleAddress | ||
| ) external; | ||
|
|
||
| /** | ||
| * @dev Mints a new token. | ||
| * @param to The address that will own the minted token. | ||
| * @param value The amount of token to be minted. | ||
| */ | ||
| function mint(address to, uint256 value) external returns (bool); |
There was a problem hiding this comment.
answer is not on l2. but there is a test to ensure that so keep the interface
aaronmgdr
reviewed
Jun 24, 2024
| * @notice Increases the variable for total amount of CELO in existence. | ||
| * @param amount The amount to increase counter by. | ||
| */ | ||
| function increaseSupply(uint256 amount) external; |
There was a problem hiding this comment.
Suggested change
| function increaseSupply(uint256 amount) external; | |
| - function increaseSupply(uint256 amount) external | |
| + function moneyPrinterGoBrbrbrbrbrbrrrrrrr(uint256 amount) external; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the distribution logic, such that CELO in no longer minted on L2, but transferred from the stash address, to the CELO recepient.
Other changes
Updated names from
GoldtoCELOTested
Unit tested