ReleaseGold L2 Compatibility Check #11005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
approved these changes
May 23, 2024
pahor167
approved these changes
May 23, 2024
jcortejoso
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the ReleaseGold test to include L2 Compatibility Check.
Other changes
Added L2 check to MockValidator contract
Tested
Unit tested
Related issues
https://github.com/celo-org/celo-blockchain-planning/issues/209
Backwards compatibility
authorizeValidatorSignerWithPublicKeyandauthorizeValidatorSignerWithKeyswill be deprecated once transitionned to L2.These functions are not critical to the ReleaseGold Contract as ReleaseGold beneficiaries can continue to use
authorizeVoteSigner.Any beneficiaries that have already used these functions to authorize signers will not encounter any issues.