Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added revert message where missing. #10340

Merged
merged 4 commits into from
Jun 2, 2023
Merged

added revert message where missing. #10340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d83b3ac
added revert message where missing.
soloseng May 27, 2023
ad08d90
add version control
soloseng May 31, 2023
533b204
Merge branch 'master' into soloseng/adding-revert-msg
soloseng Jun 1, 2023
5151c69
Merge branch 'master' into soloseng/adding-revert-msg
soloseng Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/protocol/contracts/identity/IdentityProxyHub.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ contract IdentityProxyHub is UsingRegistry {
payable
returns (bytes memory)
soloseng marked this conversation as resolved.
Show resolved Hide resolved
{
require(passesIdentityHeuristic(msg.sender, identifier));
require(passesIdentityHeuristic(msg.sender, identifier), "does not pass identity heuristic");
return getOrDeployIdentityProxy(identifier).makeCall.value(msg.value)(destination, data);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/protocol/contracts/stability/SortedOracles.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ contract SortedOracles is ISortedOracles, ICeloVersionedContract, Ownable, Initi
* @return Patch version of the contract.
*/
function getVersionNumber() external pure returns (uint256, uint256, uint256, uint256) {
return (1, 1, 2, 1);
return (1, 1, 2, 2);
}

/**
Expand Down Expand Up @@ -171,7 +171,7 @@ contract SortedOracles is ISortedOracles, ICeloVersionedContract, Ownable, Initi
* @return The address of the last report.
*/
function isOldestReportExpired(address token) public view returns (bool, address) {
require(token != address(0));
require(token != address(0), "token address cannot be null");
address oldest = timestamps[token].getTail();
uint256 timestamp = timestamps[token].getValue(oldest);
// solhint-disable-next-line not-rely-on-time
Expand Down