Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASv1-specific commands from the CLI #10179

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

eelanagaraj
Copy link
Contributor

@eelanagaraj eelanagaraj commented Feb 21, 2023

Description

Splitting up the monster sunsetting PR into smaller, more easy-to-review parts where possible.

This PR removes the following from the CLI:

  • account:claim-attestation-service-url (create an attestation service URL metadata claim)
  • identity:current-attestation-services (outputs which validators are running attestation services)
  • identity:test-attestation-service (test an attestation request against a running service to check that it's set up correctly)
  • removes displaying attestation service claims in CLI commands (utils change)

it intentionally keeps the following ASv1-related commands:

  • identity:identifier (queries ODIS for identifier)
  • identity:withdraw-attestation-rewards (make it easier for issuers to withdraw old rewards)
  • identity:get-attestations (looks up attestations for a phone number/pepper)`
    • (this one is just read functionality that will still be available going forwards which is why I kept it for now -- reviewers: definitely let me know if you see this differently)
  • all account signer authorization/deauthorization stuff (FederatedAttestations also allows for issuers to set an attestation signer role)

@eelanagaraj eelanagaraj requested a review from alecps February 21, 2023 14:31
@eelanagaraj eelanagaraj marked this pull request as ready for review February 21, 2023 16:52
@eelanagaraj eelanagaraj requested review from a team as code owners February 21, 2023 16:52
Copy link
Contributor

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooohooo!

@eelanagaraj eelanagaraj enabled auto-merge (squash) February 21, 2023 17:25
@eelanagaraj eelanagaraj merged commit 0d57cef into master Feb 21, 2023
@eelanagaraj eelanagaraj deleted the eelanagaraj/remove-asv1-from-cli branch February 22, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants