Change the event we emit when selecting issuers (#1706)

celo-org · Nov 14, 2019 · f29e6d9 · f29e6d9
1 parent 7feadc0
commit f29e6d9
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 21 deletions.
diff --git a/packages/protocol/contracts/identity/Attestations.sol b/packages/protocol/contracts/identity/Attestations.sol
@@ -95,10 +95,10 @@ contract Attestations is
     address attestationRequestFeeToken
   );
 
-  event AttestationIssuersSelected(
+  event AttestationIssuerSelected(
     bytes32 indexed identifier,
     address indexed account,
-    uint256 attestationsRequested,
+    address indexed issuer,
     address attestationRequestFeeToken
   );
 
@@ -204,13 +204,6 @@ contract Attestations is
     );
 
     addIncompleteAttestations(identifier);
-    emit AttestationIssuersSelected(
-      identifier,
-      msg.sender,
-      state.unselectedRequests[msg.sender].attestationsRequested,
-      state.unselectedRequests[msg.sender].attestationRequestFeeToken
-    );
-
     delete state.unselectedRequests[msg.sender];
   }
 
@@ -590,6 +583,13 @@ contract Attestations is
       attestation.blockNumber = unselectedRequest.blockNumber;
       attestation.attestationRequestFeeToken = unselectedRequest.attestationRequestFeeToken;
       state.selectedIssuers.push(issuer);
+
+      emit AttestationIssuerSelected(
+        identifier,
+        msg.sender,
+        issuer,
+        unselectedRequest.attestationRequestFeeToken
+      );
     }
   }
 

diff --git a/packages/protocol/test/identity/attestations.ts b/packages/protocol/test/identity/attestations.ts
@@ -459,19 +459,21 @@ contract('Attestations', (accounts: string[]) => {
           assertEqualBN(actualAttestationsRequested, 0)
         })
 
-        it('should emit the AttestationIssuersSelected event', async () => {
+        it('should emit the AttestationIssuerSelected event', async () => {
           const response = await attestations.selectIssuers(phoneHash)
-
-          assert.lengthOf(response.logs, 1)
-          const event = response.logs[0]
-          assertLogMatches2(event, {
-            event: 'AttestationIssuersSelected',
-            args: {
-              identifier: phoneHash,
-              account: caller,
-              attestationsRequested: new BigNumber(attestationsRequested),
-              attestationRequestFeeToken: mockStableToken.address,
-            },
+          const issuers = await attestations.getAttestationIssuers(phoneHash, caller)
+          assert.lengthOf(response.logs, 3)
+
+          issuers.forEach((issuer, index) => {
+            assertLogMatches2(response.logs[index], {
+              event: 'AttestationIssuerSelected',
+              args: {
+                identifier: phoneHash,
+                account: caller,
+                issuer,
+                attestationRequestFeeToken: mockStableToken.address,
+              },
+            })
           })
         })