[ASv2] PR review updates (+ solidity style guide #9651) (#9653)

* reorder functions to follow solidity style guide

* update visibility

* PR updates

* use struct to fix stack too deep

* Fix named returns

* Nits: solidity style guide reorderings

* Nit: consistent ordering for getVersionNumber with Escrow

* Remove outdated TODO - re: removed assert

Co-authored-by: Eela Nagaraj <7308464+eelanagaraj@users.noreply.github.com>

packages/protocol/contracts/identity/Escrow.sol

@@ -85,6 +85,12 @@ contract Escrow is
   // Governable list of trustedIssuers to set for payments by default.
   address[] public defaultTrustedIssuers;
 
+  /**
+   * @notice Sets initialized == true on implementation contracts
+   * @param test Set to true to skip implementation initialization
+   */
+  constructor(bool test) public Initializable(test) {}
+
   /**
    * @notice Returns the storage, major, minor, and patch version of the contract.
    * @return The storage, major, minor, and patch version of the contract.
@@ -93,12 +99,6 @@ contract Escrow is
     return (1, 2, 0, 0);
   }
 
-  /**
-   * @notice Sets initialized == true on implementation contracts
-   * @param test Set to true to skip implementation initialization
-   */
-  constructor(bool test) public Initializable(test) {}
-
   /**
    * @notice Used in place of the constructor to allow the contract to be upgradable via proxy.
    */