Add revert message to removeStorageRoot (#9010)

* Add revert message to removeStorageRoot * Update unit test
celo-org · May 13, 2022 · 932d51a · 932d51a
1 parent b5d80c7
commit 932d51a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/protocol/contracts/common/Accounts.sol b/packages/protocol/contracts/common/Accounts.sol
@@ -276,7 +276,7 @@ contract Accounts is
    */
   function removeStorageRoot(uint256 index) external {
     require(isAccount(msg.sender), "Unknown account");
-    require(index < offchainStorageRoots[msg.sender].length);
+    require(index < offchainStorageRoots[msg.sender].length, "Invalid storage root index");
     uint256 lastIndex = offchainStorageRoots[msg.sender].length - 1;
     bytes memory url = offchainStorageRoots[msg.sender][index];
     offchainStorageRoots[msg.sender][index] = offchainStorageRoots[msg.sender][lastIndex];

diff --git a/packages/protocol/test/common/accounts.ts b/packages/protocol/test/common/accounts.ts
@@ -418,8 +418,8 @@ contract('Accounts', (accounts: string[]) => {
       })
 
       describe('when there are no storage roots', async () => {
-        it('should revert', async () => {
-          await assertRevert(accountsInstance.removeStorageRoot(0))
+        it('should revert with message', async () => {
+          await assertRevert(accountsInstance.removeStorageRoot(0), 'Invalid storage root index')
         })
       })