Upgrades proof-of-possession to use Ethereum address #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd17db4 to
d0d2302
Compare
nategraf
approved these changes
Oct 29, 2019
kevjue
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the proof of possession is used with the BLS public key, opening the possibility for front-running attacks. This changes the behaviour such that the Ethereum address is used.
In conjuction with celo-org/celo-monorepo#1494.
Tested
Runs end-to-end tests in celo-monorepo.
Other changes
Related issues
Backwards compatibility
Not backwards compatible.