Fix: RPC calls (gasLimit, gasPrice) use the intial state of the block #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
+ Coverage 55.19% 55.31% +0.11%
==========================================
Files 676 676
Lines 113888 113927 +39
==========================================
+ Hits 62862 63016 +154
+ Misses 47172 47070 -102
+ Partials 3854 3841 -13
☔ View full report in Codecov by Sentry. |
|
Coverage from tests in coverage: 50.2% of statements across all listed packagescoverage: 60.2% of statements in consensus/istanbul coverage: 43.1% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.0% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
carterqw2
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RPC calls to the gasPriceMinimum and blockLimit (also ethCompatibility flag) before the gingerbreadFork (also the gasPrice for alternative currencies after the fork) require to read state from the block, but instead of reading the state from the beginning of the block, both were using the state of the end of the block
This means that the gasPrice/gasLimit of the block N that the client was sending, was actually the gasPrice/gasLimit of the block N+1
Tested
Run tests/e2e
Backwards compatibility
Yes