Improve error logging in toCeloFn #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
commented
Jul 11, 2023
Comment on lines
-390
to
+393
| curr, _ := currencyManager.GetCurrency(feeCurrency) | ||
| curr, err := currencyManager.GetCurrency(feeCurrency) | ||
| if err != nil { | ||
| log.Error("toCeloFn: could not get currency", "err", err) | ||
| } |
There was a problem hiding this comment.
This should help a lot, since we just discarded all the useful error information before.
|
Coverage from tests in coverage: 48.9% of statements across all listed packagescoverage: 63.0% of statements in consensus/istanbul coverage: 40.5% of statements in consensus/istanbul/announce coverage: 54.5% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.0% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
carterqw2
approved these changes
Jul 11, 2023
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
+ Coverage 55.17% 55.18% +0.01%
==========================================
Files 673 676 +3
Lines 113208 113888 +680
==========================================
+ Hits 62458 62849 +391
- Misses 46915 47175 +260
- Partials 3835 3864 +29
☔ View full report in Codecov by Sentry. |
This might help us debug #2134 if it happens again.
652df2a to
a10ae25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help us debug
#2134 if it happens again.