Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore opcode gas costs from Ethereum #2117

Merged
merged 14 commits into from
Jun 22, 2023
Merged

Restore opcode gas costs from Ethereum #2117

merged 14 commits into from
Jun 22, 2023

Conversation

palango
Copy link
Contributor

@palango palango commented May 30, 2023

Description

Draft implementation for celo-org/celo-proposals#367

Tested

  • Adapted existing tests to new behaviour
  • Added tests that exercise old expectations with g fork disabled
  • Updated monorepo e2e tests

Related issues

Backwards compatibility

Changes introduced at hardfork.

@palango palango changed the title Palango/reprice ops Restore opcode gas costs from Ethereum May 30, 2023
@github-actions
Copy link

github-actions bot commented May 30, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 5a4541d

coverage: 48.1% of statements across all listed packages
coverage:  58.1% of statements in consensus/istanbul
coverage:  37.9% of statements in consensus/istanbul/announce
coverage:  54.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.6% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented May 30, 2023

5830 passed, 44 skipped

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 67.61% and project coverage change: +1.08 🎉

Comparison is base (71bdbcf) 54.30% compared to head (2718ae5) 55.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2117      +/-   ##
==========================================
+ Coverage   54.30%   55.38%   +1.08%     
==========================================
  Files         692      675      -17     
  Lines      115642   113702    -1940     
==========================================
+ Hits        62795    62971     +176     
+ Misses      49014    46906    -2108     
+ Partials     3833     3825       -8     
Impacted Files Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go 0.00% <0.00%> (ø)
cmd/geth/chaincmd.go 0.00% <0.00%> (ø)
cmd/geth/config.go 0.00% <0.00%> (ø)
cmd/geth/main.go 21.39% <ø> (+0.91%) ⬆️
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.56% <0.00%> (ø)
consensus/istanbul/utils.go 47.10% <ø> (+1.13%) ⬆️
contracts/currency/currency.go 55.00% <ø> (ø)
contracts/election/election.go 25.00% <ø> (ø)
contracts/epoch_rewards/epoch_rewards.go 88.88% <ø> (ø)
... and 58 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palango palango force-pushed the palango/reprice-ops branch from a8a958f to 9db6420 Compare May 31, 2023 10:23
@palango palango marked this pull request as ready for review May 31, 2023 10:49
@palango palango requested a review from gastonponti May 31, 2023 11:13
@palango palango force-pushed the palango/reprice-ops branch from 48e07c3 to 442ba82 Compare May 31, 2023 11:24
@palango palango requested a review from hbandura June 2, 2023 09:20
core/vm/jump_table.go Outdated Show resolved Hide resolved
@palango palango force-pushed the palango/reprice-ops branch 3 times, most recently from 0abbcad to d098d42 Compare June 7, 2023 11:24
monorepo_commit Outdated Show resolved Hide resolved
@palango palango force-pushed the palango/reprice-ops branch 2 times, most recently from 540a483 to 809a9eb Compare June 13, 2023 14:17
@palango palango force-pushed the palango/reprice-ops branch from 809a9eb to 31e73ac Compare June 20, 2023 13:34
@palango palango force-pushed the palango/reprice-ops branch from 31e73ac to 031ec1d Compare June 20, 2023 14:05
@palango palango force-pushed the palango/reprice-ops branch from 031ec1d to 2b8a457 Compare June 21, 2023 09:06
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we have a possibility of a refactor there. But other than that, the PR looks good

core/vm/operations_acl.go Outdated Show resolved Hide resolved
@palango palango merged commit d68583f into master Jun 22, 2023
@palango palango deleted the palango/reprice-ops branch June 22, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants