Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetry in mechanisms to skip calling debitGasFees & creditGasFees #2267

Closed
piersy opened this issue Feb 23, 2024 · 0 comments · Fixed by #2274
Closed

Asymmetry in mechanisms to skip calling debitGasFees & creditGasFees #2267

piersy opened this issue Feb 23, 2024 · 0 comments · Fixed by #2274
Labels
theme: housekeeping About making code cleaner, more maintenability, testability, etc

Comments

@piersy
Copy link
Contributor

piersy commented Feb 23, 2024

The blockchain client skips calling debitGasFees if the fee is zero, this is to support estimating gas (gas is not charged for the credit or debit gas fees calls since they are covered by an increased intrinsic cost). However the blockchain client does not skip calling credit gas fees if the fee is zero, in fact this check is currently performed in the contract .

We should be consistent about where this functionality is skipped, or whether it is skipped at all.

Given that we just added a flag to allow explicit skipping of credit and debit calls. It seems sensible to remove all other logic to skip.

@piersy piersy added type:bug Something isn't working triage Issue needs triaging labels Feb 23, 2024
@palango palango added theme: housekeeping About making code cleaner, more maintenability, testability, etc and removed type:bug Something isn't working triage Issue needs triaging labels Feb 26, 2024
palango added a commit that referenced this issue Feb 28, 2024
This is now done by the `SkipDebitCredit` flag.

Resolves #2267
palango added a commit that referenced this issue Mar 4, 2024
This is now done by the `SkipDebitCredit` flag.

Resolves #2267
palango added a commit that referenced this issue Mar 4, 2024
This is now done by the `SkipDebitCredit` flag.

Resolves #2267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: housekeeping About making code cleaner, more maintenability, testability, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants