Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockscout] apply celo theme bis (2) #15

Merged
merged 4 commits into from
Oct 17, 2019

Conversation

jcortejoso
Copy link
Member

@jcortejoso jcortejoso commented Oct 17, 2019

Replaces #9

Motivation

Re-brand blockscout to celo theme - fixes celo-org/celo-monorepo#997 and celo-org/celo-monorepo#994

Enhancements

blockscout_new_theme

Upgrading

prerequisite: #8
once that PR is merged - this PR can point to celo-org/blockscout:master

Env vars

export NETWORK=Celo
export NETWORK_ID=11001
export SUBNETWORK=<"Celo Integration" | "Celo Alfajores" | ...>
export ETHEREUM_JSONRPC_VARIANT=geth
export ETHEREUM_JSONRPC_HTTP_URL=http://localhost:8545
export ETHEREUM_JSONRPC_TRACE_URL=http://localhost:8545
export ETHEREUM_JSONRPC_WS_URL=ws://localhost:8546
export COIN=cGLD
export WS_SECRET=<WS_SECRET>
export POSTGRES_PASSWORD=<POSTGRES_SECRET>
export LOGO=/images/celo_logo.svg

Why should we merge these changes. If using GitHub keywords to close issues, this is optional as the motivation can be read on the issue page.

Changelog

Enhancements

Things you added that don't break anything. Regression tests for Bug Fixes count as Enhancements.

Bug Fixes

Things you changed that fix bugs. If a fixes a bug, but in so doing adds a new requirement, removes code, or requires a database reset and reindex, the breaking part of the change should be added to Incompatible Changes below also.

Incompatible Changes

Things you broke while doing Enhancements and Bug Fixes. Breaking changes include (1) adding new requirements and (2) removing code. Renaming counts as (2) because a rename is a removal followed by an add.

Upgrading

If you have any Incompatible Changes in the above Changelog, outline how users of prior versions can upgrade once this PR lands or when reviewers are testing locally. A common upgrading step is "Database reset and re-index required".

@jcortejoso jcortejoso requested a review from nambrot October 17, 2019 16:57
@jcortejoso jcortejoso changed the title [blockscout] apply celo theme bis(1) [blockscout] apply celo theme bis (2) Oct 17, 2019
@jcortejoso jcortejoso changed the base branch from master to feature/sync_upstream October 17, 2019 16:59
@nambrot nambrot assigned jcortejoso and unassigned nambrot Oct 17, 2019
@jcortejoso jcortejoso changed the base branch from feature/sync_upstream to master October 17, 2019 17:25
@jcortejoso jcortejoso merged commit 93c231f into celo-org:master Oct 17, 2019
@jcortejoso jcortejoso deleted the feature/celo_theme branch October 17, 2019 17:26
aaitor added a commit that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users SBAT see Celo logo and color scheme on blockscout
3 participants