Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump versions to latest main for node and app v0.12.0-rc2 #146

Merged
merged 9 commits into from
Jan 30, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Jan 20, 2023

Overview

  • Add upd/quic-v1 to listenAddr for node's config
  • node latest main that contains v0.12.0-rc2 app
  • bumped forks of app/sdk

Ref: celestiaorg/celestia-node#1623

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 self-assigned this Jan 20, 2023
@Bidon15 Bidon15 changed the title chore: Add upd/quic-v1 to listenAddr for node's config chore: bump versions to latest main for node and app v0.12.0-rc2 Jan 24, 2023
@Bidon15 Bidon15 added enhancement New feature or request test Request for creating a test-case testground related to testground labels Jan 24, 2023
@Bidon15 Bidon15 marked this pull request as ready for review January 25, 2023 10:41
@derrandz
Copy link
Contributor

Tested against #89 in the following experimental/deletable branch and everything works fine 👍🏻

:shipit:

@derrandz derrandz self-requested a review January 25, 2023 20:03
Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@derrandz derrandz self-requested a review January 25, 2023 22:15
Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, I made a mistake. The build passes, however upon running a testcase, BuildValidator fails due to the following error:

{"ts":1674683250413689791,"msg":"","group_id":"validators","run_id":"cf8q60926unehbdhhsdg","event":{"crash_event":{"group":"validators","error":"goroutine 114 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0x65\ngithub.com/testground/sdk-go/run.HandlePanics()\n\t/go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/panic.go:23 +0x39\npanic({0x28654e0, 0x3ba7620})\n\t/usr/local/go/src/runtime/panic.go:884 +0x212\ngithub.com/cosmos/cosmos-sdk/types.(*Config).assertNotSealed(0xc001696840)\n\t

/go/pkg/mod/github.com/!bidon15/cosmos-sdk@v1.6.1-dirty-sdk-v0.46.7/types/config.go:81
        +0xa7\ngithub.com/cosmos/cosmos-sdk/types.(*Config).SetBech32PrefixForAccount(...)\n\t
        /go/pkg/mod/github.com/!bidon15/cosmos-sdk@v1.6.1-dirty-sdk-v0.46.7/types/config.go:88\n
        github.com/celestiaorg/celestia-app/cmd/celestia-appd/cmd.NewRootCmd()\n\t
        /go/pkg/mod/github.com/!bidon15/lazyledger-app@v1.12.0-dirty-app/cmd/celestia-appd/cmd/root.go:51 +0x111\n
        github.com/celestiaorg/test-infra/testkit/appkit.New(...)\n\t
        /plan/testkit/appkit/app.go:49\n
        github.com/celestiaorg/test-infra/tests/helpers/common.BuildValidator({0x3bdbcb0, 0xc0018e8a80}, 0xc001444480, 0xc00188f0e0, {0xc001a7fdf0?, 0x1, 0x0?})\n\t
        /plan/tests/helpers/common/validator.go:30 +0x8e\n
        github.com/celestiaorg/test-infra/tests/helpers/das-benchmarks.RunValidator(0xc001444480, 0xc00188f0e0)\n\t
        /plan/tests/helpers/das-benchmarks/run_validator.go:51 +0x385\n
        github.com/celestiaorg/test-infra/tests/plans/das-benchmarks.LightsDasingLatest(0xc001444480, 0xc001444480?)\n\t
        /plan/tests/plans/das-benchmarks/001-lights-dasing-latest-from-bridge.go:14 +0xcc\n
        github.com/testground/sdk-go/run.invoke.func4()\n\t
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:173 +0x142
        \ncreated by github.com/testground/sdk-go/run.invoke\n\t
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:162 +0x78c\n",
        "stacktrace":"goroutine 1 [running]:\nruntime/debug.Stack()\n\t
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65\n
        github.com/testground/sdk-go/runtime.(*RunEnv).RecordCrash(0xc001444480, {0x28654e0?, 0xc00057c200?})\n\t
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/runtime/runenv_events.go:246 +0x7b\n
        github.com/testground/sdk-go/run.invoke(0xc001444480, {0x28dc540?, 0x371dea8})\n\t
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:190 +0x8e5\n
        github.com/testground/sdk-go/run.InvokeMap(0xc0000061a0?)\n\t
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:77 +0x94\nmain.main()\n\t
        /plan/main.go:30 +0x25\n"}}}
Config is sealed
goroutine 1 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65
runtime/debug.PrintStack()
        /usr/local/go/src/runtime/debug/stack.go:16 +0x19
github.com/testground/sdk-go/run.invoke.func3()
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:151 +0x8a
panic({0x28654e0, 0x3ba7620})
        /usr/local/go/src/runtime/panic.go:884 +0x212
github.com/testground/sdk-go/run.invoke(0xc001444480, {0x28dc540?, 0x371dea8})
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:191 +0x8f7
github.com/testground/sdk-go/run.InvokeMap(0xc0000061a0?)
        /go/pkg/mod/github.com/testground/sdk-go@v0.3.0/run/invoker.go:77 +0x94
main.main()
        /plan/main.go:30 +0x25

Not sure how to resolve this yet, I've tried skipping the reconfiguration in testkit/nodekit/node.go in NewNode however the issue persists and validator can't come up.

@Bidon15 Bidon15 requested a review from derrandz January 27, 2023 16:12
@Bidon15 Bidon15 merged commit fd0e4a7 into celestiaorg:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Request for creating a test-case testground related to testground
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants