Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplication #87

Merged
merged 2 commits into from
Jun 20, 2023
Merged

remove duplication #87

merged 2 commits into from
Jun 20, 2023

Conversation

Ehsanino82
Copy link
Contributor

@Ehsanino82 Ehsanino82 commented Jun 17, 2023 •
edited by smuu
Loading

Resolves #45

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Ehsanino82
Copy link
Contributor Author

#45
handle this issue

smuu
smuu requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution 🚀

Only one small thing, and then we can merge your PR :)

pkg/knuu/instance.go Outdated Show resolved Hide resolved
@Ehsanino82
Copy link
Contributor Author

Looks good! Thanks for your contribution rocket

Only one small thing, and then we can merge your PR :)

I apply the change you want,

@smuu smuu merged commit acb4d43 into celestiaorg:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuu smuu smuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicate code - cloning
2 participants
@Ehsanino82 @smuu