Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check if knuu was initialized #67

Merged
merged 2 commits into from
Jun 16, 2023
Merged

feat: add check if knuu was initialized #67

merged 2 commits into from
Jun 16, 2023

Conversation

smuu
Copy link
Member

@smuu smuu commented Jun 15, 2023

Resolves #58

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@smuu smuu force-pushed the feature/check-if-init branch from f82cd36 to 18bb5d4 Compare June 15, 2023 12:14
This was referenced Jun 16, 2023
Merged
Merged
@smuu
feat: add check if knuu was initialized
7605203 
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu force-pushed the feature/check-if-init branch from 18bb5d4 to 7605203 Compare June 16, 2023 11:34
tty47
tty47 previously approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tty47
tty47 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smuu smuu merged commit f2f5889 into main Jun 16, 2023
@smuu smuu deleted the feature/check-if-init branch June 16, 2023 12:28
@smuu smuu mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Celestia DevOps/Testing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When knuu is not initialized, it panics when calling kubernetes
2 participants
@smuu @tty47