-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: refactor Traefik pkg to receive a logger object #471
chore!: refactor Traefik pkg to receive a logger object #471
Conversation
Warning Review failedThe pull request is closed. WalkthroughThe recent changes refactor the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- pkg/knuu/knuu.go (1 hunks)
- pkg/traefik/traefik.go (15 hunks)
Additional comments not posted (9)
pkg/knuu/knuu.go (1)
233-234
: Ensure proper initialization and usage of the Logger field in Traefik struct.The
Logger
field is correctly initialized in theTraefik
struct. Ensure that this logger is used consistently for logging within the Traefik package.pkg/traefik/traefik.go (8)
44-46
: Ensure Logger field is correctly initialized and used.The
Logger
field is correctly added to theTraefik
struct. Ensure that all logging within theTraefik
struct uses this logger instance.
Line range hint
50-59
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across theDeploy
method. This change improves clarity and consistency.Also applies to: 69-69, 95-95, 120-120, 165-165, 170-170, 178-178
186-186
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across theIP
method. This change improves clarity and consistency.Also applies to: 190-190
204-204
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across theEndpoint
method. This change improves clarity and consistency.Also applies to: 207-207
226-226
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across thecreateService
method. This change improves clarity and consistency.Also applies to: 231-231, 258-258
269-269
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across thecreateMiddleware
method. This change improves clarity and consistency.Also applies to: 285-285
315-315
: Consistency in field renaming: K8s to K8sClient.The field renaming from
K8s
toK8sClient
is consistently applied across thecreateIngressRoute
method. This change improves clarity and consistency.Also applies to: 340-340
350-352
: Update logging to use the Logger field in IsTraefikAPIAvailable method.The logging in the
IsTraefikAPIAvailable
method has been updated to use theLogger
field of theTraefik
struct. This change ensures that the custom logger is used for logging.Also applies to: 371-371
…ve-a-logger-object
Closes #448
Summary by CodeRabbit
New Features
Traefik
integration by adding logging capabilities.Refactor
Traefik
methods to useK8sClient
instead ofK8s
for Kubernetes operations.Bug Fixes
Traefik
methods for better debug and monitoring.